extensions/renderer/resources/utils.js - Issue 482603002: Unify logic of stack trace generation for extension errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/utils.js

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add $Error and $String.indexOf to safe builtins Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/resources/uncaught_exception_handler.js ('K') | « extensions/renderer/resources/uncaught_exception_handler.js ('k') | extensions/renderer/safe_builtins.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/utils.js

diff --git a/extensions/renderer/resources/utils.js b/extensions/renderer/resources/utils.js

index 803a3518d753b271bf740dd982d51d8af86c4720..11eededc22ddf91d38bb74c1a8765c90d9292be4 100644

--- a/extensions/renderer/resources/utils.js

+++ b/extensions/renderer/resources/utils.js

@@ -38,8 +38,8 @@ function lookup(array_of_dictionaries, field, value) {

} else if (matches.length == 1) {

return matches[0]

} else {

- throw new Error("Failed lookup of field '" + field + "' with value '" +

- value + "'");

+ throw new $Error.self(

not at google - send to devlin 2014/08/19 16:45:56 I have no idea about this one.

+ "Failed lookup of field '" + field + "' with value '" + value + "'");

}