extensions/renderer/resources/test_custom_bindings.js - Issue 482603002: Unify logic of stack trace generation for extension errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/test_custom_bindings.js

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add $Error and $String.indexOf to safe builtins Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/resources/set_icon.js ('K') | « extensions/renderer/resources/set_icon.js ('k') | extensions/renderer/resources/uncaught_exception_handler.js » ('j') | extensions/renderer/resources/uncaught_exception_handler.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/test_custom_bindings.js

diff --git a/extensions/renderer/resources/test_custom_bindings.js b/extensions/renderer/resources/test_custom_bindings.js

index 188a9c8168f32b7c6c20e921925505908c697f4d..a4edd027ae07e433415101d5b12f7f7605918819 100644

--- a/extensions/renderer/resources/test_custom_bindings.js

+++ b/extensions/renderer/resources/test_custom_bindings.js

@@ -62,9 +62,9 @@ binding.registerCustomHook(function(api) {

'First call:\n' +

$String.slice(called, redundantPrefix.length) + '\n' +

'Second call:\n' +

- $String.slice(new Error().stack, redundantPrefix.length));

+ $String.slice(new $Error.self().stack, redundantPrefix.length));

}

- called = new Error().stack;

+ called = new $Error.self().stack;

pendingCallbacks--;

if (pendingCallbacks == 0) {