Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2327)

Unified Diff: extensions/renderer/resources/binding.js

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Processed reviewers' comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/binding.js
diff --git a/extensions/renderer/resources/binding.js b/extensions/renderer/resources/binding.js
index be2056a4e9a0085d63d97f29dfae63a1fe10e629..c95cf854c16b529ad668eb8747356f19531d604a 100644
--- a/extensions/renderer/resources/binding.js
+++ b/extensions/renderer/resources/binding.js
@@ -5,6 +5,8 @@
var Event = require('event_bindings').Event;
var forEach = require('utils').forEach;
var GetAvailability = requireNative('v8_context').GetAvailability;
+var getExtensionStackTrace =
+ require('uncaught_exception_handler').getExtensionStackTrace;
var lastError = require('lastError');
var logActivity = requireNative('activityLogger');
var logging = requireNative('logging');
@@ -69,7 +71,7 @@ APIFunctions.prototype.setHandleRequestWithPromise =
return this.setHook_(apiName, 'handleRequest', function() {
var name = prefix + '.' + apiName;
logActivity.LogAPICall(extensionId, name, $Array.slice(arguments));
- var stack = sendRequestHandler.getExtensionStackTrace();
+ var stack = getExtensionStackTrace();
var callback = arguments[arguments.length - 1];
var args = $Array.slice(arguments, 0, arguments.length - 1);
$Function.apply(customizedFunction, this, args).then(function(result) {

Powered by Google App Engine
This is Rietveld 408576698