Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: extensions/renderer/resources/event.js

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update expected stack trace length Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/resources/binding.js ('k') | extensions/renderer/resources/send_request.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/event.js
diff --git a/extensions/renderer/resources/event.js b/extensions/renderer/resources/event.js
index d82b9fb141d2f8b73969b7632cee6cafed39192a..f62ab0ff21752e49a378396905b48c2d51bf2d98 100644
--- a/extensions/renderer/resources/event.js
+++ b/extensions/renderer/resources/event.js
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+ var exceptionHandler = require('uncaught_exception_handler');
var eventNatives = requireNative('event_natives');
- var handleUncaughtException = require('uncaught_exception_handler').handle;
var logging = requireNative('logging');
var schemaRegistry = requireNative('schema_registry');
var sendRequest = require('sendRequest').sendRequest;
@@ -381,10 +381,8 @@
if (result !== undefined)
$Array.push(results, result);
} catch (e) {
- handleUncaughtException(
- 'Error in event handler for ' +
- (this.eventName ? this.eventName : '(unknown)') +
- ': ' + e.message + '\nStack trace: ' + e.stack,
+ exceptionHandler.handle('Error in event handler for ' +
+ (this.eventName ? this.eventName : '(unknown)'),
e);
}
}
@@ -411,7 +409,7 @@
EventImpl.prototype.destroy_ = function() {
this.listeners.length = 0;
this.detach_();
- this.destroyed = new Error().stack;
+ this.destroyed = exceptionHandler.getStackTrace();
};
EventImpl.prototype.addRules = function(rules, opt_cb) {
« no previous file with comments | « extensions/renderer/resources/binding.js ('k') | extensions/renderer/resources/send_request.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698