extensions/renderer/module_system.cc - Issue 482603002: Unify logic of stack trace generation for extension errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/module_system.cc

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update expected stack trace length Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/bindings/exception_in_handler_should_not_crash/page.js ('k') | extensions/renderer/resources/binding.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/module_system.cc

diff --git a/extensions/renderer/module_system.cc b/extensions/renderer/module_system.cc

index 1f337643476d06ad230eab1fb4949e61ec616a8f..5938556191ae68976accf72d8f6e60bc23eb40ec 100644

--- a/extensions/renderer/module_system.cc

+++ b/extensions/renderer/module_system.cc

@@ -551,7 +551,7 @@ v8::Handle<v8::String> ModuleSystem::WrapSource(v8::Handle<v8::String> source) {

GetIsolate(),

"(function(define, require, requireNative, requireAsync, exports, "

"console, privates,"

- "$Array, $Function, $JSON, $Object, $RegExp, $String) {"

+ "$Array, $Function, $JSON, $Object, $RegExp, $String, $Error) {"

"'use strict';");

v8::Handle<v8::String> right = v8::String::NewFromUtf8(GetIsolate(), "\n})");

return handle_scope.Escape(v8::Local<v8::String>(

@@ -624,6 +624,7 @@ v8::Handle<v8::Value> ModuleSystem::LoadModule(const std::string& module_name) {

context_->safe_builtins()->GetObjekt(),

context_->safe_builtins()->GetRegExp(),

context_->safe_builtins()->GetString(),

+ context_->safe_builtins()->GetError(),

};

{

v8::TryCatch try_catch;