chrome/renderer/resources/extensions/page_capture_custom_bindings.js - Issue 482603002: Unify logic of stack trace generation for extension errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/page_capture_custom_bindings.js

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/file_system_custom_bindings.js ('k') | chrome/test/data/extensions/api_test/bindings/exception_in_handler_should_not_crash/page.js » ('j') | chrome/test/data/extensions/api_test/bindings/exception_in_handler_should_not_crash/page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/page_capture_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/page_capture_custom_bindings.js b/chrome/renderer/resources/extensions/page_capture_custom_bindings.js

index a7a140af0a980393147ee0eb8d5bf9dccc09c422..18482975fdb941cfca9aa4ea7d7d74ebead71d0f 100644

--- a/chrome/renderer/resources/extensions/page_capture_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/page_capture_custom_bindings.js

@@ -24,10 +24,8 @@ binding.registerCustomHook(function(bindingsAPI) {

try {

callback(response);

} catch (e) {

- var message = "Error in chrome.pageCapture.saveAsMHTML callback: " + e;

- if (request.stack)

- message += "\n" + request.stack;

- handleUncaughtException(message, e);

+ handleUncaughtException(

+ 'Error in chrome.pageCapture.saveAsMHTML callback', e, request.stack);

} finally {

// Notify the browser. Now that the blob is referenced from JavaScript,

// the browser can drop its reference to it.