Unify logic of stack trace generation for extension errors

extensions/renderer/safe_builtins.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/safe_builtins.h"
 
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "base/strings/stringprintf.h"
 #include "extensions/renderer/script_context.h"
@@ skipping 23 matching lines @@
     "\n"
     "// Used in the callback implementation, could potentially be clobbered.\n"
     "function makeCallable(obj, target, isStatic, propertyNames) {\n"
     "  propertyNames.forEach(function(propertyName) {\n"
     "    var property = obj[propertyName];\n"
     "    target[propertyName] = function() {\n"
     "      var recv = obj;\n"
     "      var firstArgIndex = 0;\n"
     "      if (!isStatic) {\n"
     "        if (arguments.length == 0)\n"
-    "          throw 'There must be at least one argument, the recevier';\n"
+    "          throw 'There must be at least one argument, the receiver';\n"
     "        recv = arguments[0];\n"
     "        firstArgIndex = 1;\n"
     "      }\n"
     "      return Apply(\n"
     "          property, recv, arguments, firstArgIndex, arguments.length);\n"
     "    };\n"
     "  });\n"
     "}\n"
     "\n"
     "function saveBuiltin(builtin, protoPropertyNames, staticPropertyNames) {\n"
     "  var safe = function() {\n"
     "    throw 'Safe objects cannot be called nor constructed. ' +\n"
     "          'Use $Foo.self() or new $Foo.self() instead.';\n"
     "  };\n"
     "  safe.self = builtin;\n"
     "  makeCallable(builtin.prototype, safe, false, protoPropertyNames);\n"
     "  if (staticPropertyNames)\n"
     "    makeCallable(builtin, safe, true, staticPropertyNames);\n"
     "  Save(builtin.name, safe);\n"
     "}\n"
     "\n"
-    "// Save only what is needed to make tests that override builtins pass.\n"
+    "// Save only what is needed by the extension modules.\n"
     "saveBuiltin(Object,\n"
     "            ['hasOwnProperty'],\n"
     "            ['create', 'defineProperty', 'getOwnPropertyDescriptor',\n"
     "             'getPrototypeOf', 'keys']);\n"
     "saveBuiltin(Function,\n"
     "            ['apply', 'bind', 'call']);\n"
     "saveBuiltin(Array,\n"
     "            ['concat', 'forEach', 'indexOf', 'join', 'push', 'slice',\n"
     "             'splice', 'map', 'filter']);\n"
     "saveBuiltin(String,\n"
-    "            ['slice', 'split']);\n"
+    "            ['indexOf', 'slice', 'split']);\n"
     "saveBuiltin(RegExp,\n"
     "            ['test']);\n"
+    "saveBuiltin(Error,\n"
+    "            [],\n"
+    "            ['captureStackTrace']);\n"
     "\n"
     "// JSON is trickier because extensions can override toJSON in\n"
     "// incompatible ways, and we need to prevent that.\n"
     "var builtinTypes = [\n"
     "  Object, Function, Array, String, Boolean, Number, Date, RegExp\n"
     "];\n"
     "var builtinToJSONs = builtinTypes.map(function(t) {\n"
     "  return t.toJSON;\n"
     "});\n"
     "var builtinArray = Array;\n"
@@ skipping 133 matching lines @@
 }
 
 v8::Local<v8::Object> SafeBuiltins::GetRegExp() const {
   return Load("RegExp", context_->v8_context());
 }
 
 v8::Local<v8::Object> SafeBuiltins::GetString() const {
   return Load("String", context_->v8_context());
 }
 
+v8::Local<v8::Object> SafeBuiltins::GetError() const {
+  return Load("Error", context_->v8_context());
+}
+
 }  //  namespace extensions