Unify logic of stack trace generation for extension errors

extensions/renderer/resources/schema_utils.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Routines used to validate and normalize arguments.
 // TODO(benwells): unit test this file.
 
 var JSONSchemaValidator = require('json_schema').JSONSchemaValidator;
 
 var schemaValidator = new JSONSchemaValidator();
 
 // Validate arguments.
 function validate(args, parameterSchemas) {
   if (args.length > parameterSchemas.length)
-    throw new Error("Too many arguments.");
+    throw new $Error.self("Too many arguments.");
   for (var i = 0; i < parameterSchemas.length; i++) {
     if (i in args && args[i] !== null && args[i] !== undefined) {
       schemaValidator.resetErrors();
       schemaValidator.validate(args[i], parameterSchemas[i]);
       if (schemaValidator.errors.length == 0)
         continue;
       var message = "Invalid value for argument " + (i + 1) + ". ";
       for (var i = 0, err;
           err = schemaValidator.errors[i]; i++) {
         if (err.path) {
           message += "Property '" + err.path + "': ";
         }
         message += err.message;
         message = message.substring(0, message.length - 1);
         message += ", ";
       }
       message = message.substring(0, message.length - 2);
       message += ".";
-      throw new Error(message);
+      throw new $Error.self(message);
     } else if (!parameterSchemas[i].optional) {
-      throw new Error("Parameter " + (i + 1) + " (" +
+      throw new $Error.self("Parameter " + (i + 1) + " (" +
           parameterSchemas[i].name + ") is required.");
     }
   }
 }
 
 // Generate all possible signatures for a given API function.
 function getSignatures(parameterSchemas) {
   if (parameterSchemas.length === 0)
     return [[]];
   var signatures = [];
@@ skipping 56 matching lines @@
 // where nulls are inserted where optional parameters were omitted.
 // |args| is expected to be an array.
 function normalizeArgumentsAndValidate(args, funDef) {
   if (funDef.allowAmbiguousOptionalArguments) {
     validate(args, funDef.definition.parameters);
     return args;
   }
   var definedSignature = funDef.definition.parameters;
   var resolvedSignature = resolveSignature(args, definedSignature);
   if (!resolvedSignature)
-    throw new Error("Invocation of form " +
+    throw new $Error.self("Invocation of form " +

[not at google - send to devlin, 2014/08/19 16:45:56]

new Error() for this whole file.

         getArgumentSignatureString(funDef.name, args) +
         " doesn't match definition " +
         getParameterSignatureString(funDef.name, definedSignature));
   validate(args, resolvedSignature);
   var normalizedArgs = [];
   var ai = 0;
   for (var si = 0; si < definedSignature.length; si++) {
     if (definedSignature[si] === resolvedSignature[ai])
       $Array.push(normalizedArgs, args[ai++]);
     else
@@ skipping 23 matching lines @@
         return true;
     }
   }
   return false;
 };
 
 exports.isFunctionSignatureAmbiguous = isFunctionSignatureAmbiguous;
 exports.normalizeArgumentsAndValidate = normalizeArgumentsAndValidate;
 exports.schemaValidator = schemaValidator;
 exports.validate = validate;