Unify logic of stack trace generation for extension errors

extensions/renderer/resources/runtime_custom_bindings.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Custom binding for the runtime API.
 
 var binding = require('binding').Binding.create('runtime');
 
 var messaging = require('messaging');
 var runtimeNatives = requireNative('runtime');
@@ skipping 121 matching lines @@
     var targetId = null;
     if (typeof(arguments[nextArg]) == 'string')
       targetId = arguments[nextArg++];
 
     // connectInfo (second argument) is optional.
     var connectInfo = null;
     if (typeof(arguments[nextArg]) == 'object')
       connectInfo = arguments[nextArg++];
 
     if (nextArg != arguments.length)
-      throw new Error('Invalid arguments to connect.');
+      throw new $Error.self('Invalid arguments to connect.');

[not at google - send to devlin, 2014/08/19 16:45:56]

new Error()

     return [targetId, connectInfo];
   });
 
   apiFunctions.setUpdateArgumentsPreValidate('connectNative',
                                              function(appName) {
     if (typeof(appName) !== 'string') {
-      throw new Error('Invalid arguments to connectNative.');
+      throw new $Error.self('Invalid arguments to connectNative.');

[not at google - send to devlin, 2014/08/19 16:45:56]

new Error()

     }
     return [appName];
   });
 
   apiFunctions.setHandleRequest('connect', function(targetId, connectInfo) {
     // Don't let orphaned content scripts communicate with their extension.
     // http://crbug.com/168263
     if (unloadEvent.wasDispatched)
-      throw new Error('Error connecting to extension ' + targetId);
+      throw new $Error.self('Error connecting to extension ' + targetId);

[not at google - send to devlin, 2014/08/19 16:45:56]

new Error()

 
     if (!targetId)
       targetId = runtime.id;
 
     var name = '';
     if (connectInfo && connectInfo.name)
       name = connectInfo.name;
 
     var includeTlsChannelId =
       !!(connectInfo && connectInfo.includeTlsChannelId);
@@ skipping 11 matching lines @@
     return;
 
   apiFunctions.setHandleRequest('connectNative',
                                 function(nativeAppName) {
     if (!unloadEvent.wasDispatched) {
       var portId = runtimeNatives.OpenChannelToNativeApp(runtime.id,
                                                          nativeAppName);
       if (portId >= 0)
         return messaging.createPort(portId, '');
     }
-    throw new Error('Error connecting to native app: ' + nativeAppName);
+    throw new $Error.self('Error connecting to native app: ' + nativeAppName);

[not at google - send to devlin, 2014/08/19 16:45:56]

new Error() ... I think.

   });
 
   apiFunctions.setCustomCallback('getBackgroundPage',
                                  function(name, request, response) {
     if (request.callback) {
       var bg = runtimeNatives.GetExtensionViews(-1, 'BACKGROUND')[0] || null;
       request.callback(bg);
     }
     request.callback = null;
   });
 
   bindDirectoryEntryCallback('getPackageDirectoryEntry', apiFunctions);
 });
 
 exports.bindDirectoryEntryCallback = bindDirectoryEntryCallback;
 exports.binding = binding.generate();