Unify logic of stack trace generation for extension errors

extensions/renderer/resources/messaging.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // chrome.runtime.messaging API implementation.
 
   // TODO(kalman): factor requiring chrome out of here.
   var chrome = requireNative('chrome').GetChrome();
   var Event = require('event_bindings').Event;
   var lastError = require('lastError');
@@ skipping 84 matching lines @@
   // the C++ to avoid creating the javascript message for all the contexts that
   // don't care about a particular message.
   function hasPort(portId) {
     return portId in ports;
   };
 
   // Hidden port creation function.  We don't want to expose an API that lets
   // people add arbitrary port IDs to the port list.
   function createPort(portId, opt_name) {
     if (ports[portId])
-      throw new Error("Port '" + portId + "' already exists.");
+      throw new $Error.self("Port '" + portId + "' already exists.");
     var port = new Port(portId, opt_name);
     ports[portId] = port;
     portReleasers[portId] = $Function.bind(messagingNatives.PortRelease,
                                            this,
                                            portId);
     unloadEvent.addListener(portReleasers[portId]);
     messagingNatives.PortAddRef(portId);
     return port;
   };
 
@@ skipping 234 matching lines @@
     port.onDisconnect.addListener(disconnectListener);
     port.onMessage.addListener(messageListener);
   };
 
   function sendMessageUpdateArguments(functionName, hasOptionsArgument) {
     // skip functionName and hasOptionsArgument
     var args = $Array.slice(arguments, 2);
     var alignedArgs = messagingUtils.alignSendMessageArguments(args,
         hasOptionsArgument);
     if (!alignedArgs)
-      throw new Error('Invalid arguments to ' + functionName + '.');
+      throw new $Error.self('Invalid arguments to ' + functionName + '.');

[not at google - send to devlin, 2014/08/19 16:45:56]

new Error()

     return alignedArgs;
   }
 
 var Port = utils.expose('Port', PortImpl, { functions: [
     'disconnect',
     'postMessage'
   ],
   properties: [
     'name',
     'onDisconnect',
     'onMessage'
   ] });
 
 exports.kRequestChannel = kRequestChannel;
 exports.kMessageChannel = kMessageChannel;
 exports.kNativeMessageChannel = kNativeMessageChannel;
 exports.Port = Port;
 exports.createPort = createPort;
 exports.sendMessageImpl = sendMessageImpl;
 exports.sendMessageUpdateArguments = sendMessageUpdateArguments;
 
 // For C++ code to call.
 exports.hasPort = hasPort;
 exports.dispatchOnConnect = dispatchOnConnect;
 exports.dispatchOnDisconnect = dispatchOnDisconnect;
 exports.dispatchOnMessage = dispatchOnMessage;