Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: extensions/renderer/resources/extension_custom_bindings.js

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add $Error and $String.indexOf to safe builtins Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom binding for the extension API. 5 // Custom binding for the extension API.
6 6
7 var binding = require('binding').Binding.create('extension'); 7 var binding = require('binding').Binding.create('extension');
8 8
9 var messaging = require('messaging'); 9 var messaging = require('messaging');
10 var runtimeNatives = requireNative('runtime'); 10 var runtimeNatives = requireNative('runtime');
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 } 85 }
86 }); 86 });
87 87
88 apiFunctions.setUpdateArgumentsPreValidate('sendRequest', 88 apiFunctions.setUpdateArgumentsPreValidate('sendRequest',
89 $Function.bind(messaging.sendMessageUpdateArguments, 89 $Function.bind(messaging.sendMessageUpdateArguments,
90 null, 'sendRequest', false /* hasOptionsArgument */)); 90 null, 'sendRequest', false /* hasOptionsArgument */));
91 91
92 apiFunctions.setHandleRequest('sendRequest', 92 apiFunctions.setHandleRequest('sendRequest',
93 function(targetId, request, responseCallback) { 93 function(targetId, request, responseCallback) {
94 if (sendRequestIsDisabled) 94 if (sendRequestIsDisabled)
95 throw new Error(sendRequestIsDisabled); 95 throw new $Error.self(sendRequestIsDisabled);
96 var port = chrome.runtime.connect(targetId || extensionId, 96 var port = chrome.runtime.connect(targetId || extensionId,
97 {name: messaging.kRequestChannel}); 97 {name: messaging.kRequestChannel});
98 messaging.sendMessageImpl(port, request, responseCallback); 98 messaging.sendMessageImpl(port, request, responseCallback);
99 }); 99 });
100 100
101 if (sendRequestIsDisabled) { 101 if (sendRequestIsDisabled) {
102 extension.onRequest.addListener = function() { 102 extension.onRequest.addListener = function() {
103 throw new Error(sendRequestIsDisabled); 103 throw new $Error.self(sendRequestIsDisabled);
104 }; 104 };
105 if (contextType == 'BLESSED_EXTENSION') { 105 if (contextType == 'BLESSED_EXTENSION') {
106 extension.onRequestExternal.addListener = function() { 106 extension.onRequestExternal.addListener = function() {
107 throw new Error(sendRequestIsDisabled); 107 throw new $Error.self(sendRequestIsDisabled);
not at google - send to devlin 2014/08/19 16:45:55 All of these: new Error()
108 }; 108 };
109 } 109 }
110 } 110 }
111 }); 111 });
112 112
113 exports.binding = binding.generate(); 113 exports.binding = binding.generate();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698