Unify logic of stack trace generation for extension errors

extensions/renderer/resources/binding.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var Event = require('event_bindings').Event;
 var forEach = require('utils').forEach;
 var GetAvailability = requireNative('v8_context').GetAvailability;
+var exceptionHandler = require('uncaught_exception_handler');
 var lastError = require('lastError');
 var logActivity = requireNative('activityLogger');
 var logging = requireNative('logging');
 var process = requireNative('process');
 var schemaRegistry = requireNative('schema_registry');
 var schemaUtils = require('schemaUtils');
 var utils = require('utils');
 var sendRequestHandler = require('sendRequest');
 
 var contextType = process.GetContextType();
@@ skipping 44 matching lines @@
       return ret;
     });
 };
 
 APIFunctions.prototype.setHandleRequestWithPromise =
     function(apiName, customizedFunction) {
   var prefix = this.namespace;
   return this.setHook_(apiName, 'handleRequest', function() {
       var name = prefix + '.' + apiName;
       logActivity.LogAPICall(extensionId, name, $Array.slice(arguments));
-      var stack = sendRequestHandler.getExtensionStackTrace();
+      var stack = exceptionHandler.getExtensionStackTrace();
       var callback = arguments[arguments.length - 1];
       var args = $Array.slice(arguments, 0, arguments.length - 1);
       $Function.apply(customizedFunction, this, args).then(function(result) {
         sendRequestHandler.safeCallbackApply(
             name, {'stack': stack}, callback, [result]);
       }).catch(function(error) {
-        lastError.run(name, error.message, stack, callback);
+        var message = exceptionHandler.safeErrorToString(error, true);
+        lastError.run(name, message, stack, callback);
       });
     });
 };
 
 APIFunctions.prototype.setUpdateArgumentsPostValidate =
     function(apiName, customizedFunction) {
   return this.setHook_(
     apiName, 'updateArgumentsPostValidate', customizedFunction);
 };
 
@@ skipping 37 matching lines @@
   for (var i = 0; i < platforms.length; i++) {
     if ($RegExp.test(platforms[i][0], navigator.appVersion)) {
       return platforms[i][1];
     }
   }
   return "unknown";
 }
 
 function isPlatformSupported(schemaNode, platform) {
   return !schemaNode.platforms ||
-      schemaNode.platforms.indexOf(platform) > -1;
+      $Array.indexOf(schemaNode.platforms, platform) > -1;
 }
 
 function isManifestVersionSupported(schemaNode, manifestVersion) {
   return !schemaNode.maximumManifestVersion ||
       manifestVersion <= schemaNode.maximumManifestVersion;
 }
 
 function isSchemaNodeSupported(schemaNode, platform, manifestVersion) {
   return isPlatformSupported(schemaNode, platform) &&
       isManifestVersionSupported(schemaNode, manifestVersion);
@@ skipping 322 matching lines @@
                     availability.message);
       return;
     }
 
     this.runHooks_(mod);
     return mod;
   }
 };
 
 exports.Binding = Binding;