Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Side by Side Diff: chrome/renderer/resources/extensions/page_capture_custom_bindings.js

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update expected stack trace length Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom binding for the pageCapture API. 5 // Custom binding for the pageCapture API.
6 6
7 var binding = require('binding').Binding.create('pageCapture'); 7 var binding = require('binding').Binding.create('pageCapture');
8 8
9 var handleUncaughtException = require('uncaught_exception_handler').handle; 9 var handleUncaughtException = require('uncaught_exception_handler').handle;
10 var pageCaptureNatives = requireNative('page_capture'); 10 var pageCaptureNatives = requireNative('page_capture');
11 var CreateBlob = pageCaptureNatives.CreateBlob; 11 var CreateBlob = pageCaptureNatives.CreateBlob;
12 var SendResponseAck = pageCaptureNatives.SendResponseAck; 12 var SendResponseAck = pageCaptureNatives.SendResponseAck;
13 13
14 binding.registerCustomHook(function(bindingsAPI) { 14 binding.registerCustomHook(function(bindingsAPI) {
15 var apiFunctions = bindingsAPI.apiFunctions; 15 var apiFunctions = bindingsAPI.apiFunctions;
16 16
17 apiFunctions.setCustomCallback('saveAsMHTML', 17 apiFunctions.setCustomCallback('saveAsMHTML',
18 function(name, request, response) { 18 function(name, request, response) {
19 var callback = request.callback; 19 var callback = request.callback;
20 request.callback = null; 20 request.callback = null;
21 if (response) 21 if (response)
22 response = CreateBlob(response.mhtmlFilePath, response.mhtmlFileLength); 22 response = CreateBlob(response.mhtmlFilePath, response.mhtmlFileLength);
23 23
24 try { 24 try {
25 callback(response); 25 callback(response);
26 } catch (e) { 26 } catch (e) {
27 var message = "Error in chrome.pageCapture.saveAsMHTML callback: " + e; 27 handleUncaughtException(
28 if (request.stack) 28 'Error in chrome.pageCapture.saveAsMHTML callback', e, request.stack);
29 message += "\n" + request.stack;
30 handleUncaughtException(message, e);
31 } finally { 29 } finally {
32 // Notify the browser. Now that the blob is referenced from JavaScript, 30 // Notify the browser. Now that the blob is referenced from JavaScript,
33 // the browser can drop its reference to it. 31 // the browser can drop its reference to it.
34 SendResponseAck(request.id); 32 SendResponseAck(request.id);
35 } 33 }
36 }); 34 });
37 }); 35 });
38 36
39 exports.binding = binding.generate(); 37 exports.binding = binding.generate();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698