Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: pkg/analysis_server/test/services/correction/change_test.dart

Issue 482573004: Change analysis server protocol to omit empty lists when optional. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.services.correction.change; 5 library test.services.correction.change;
6 6
7 import 'package:analysis_server/src/constants.dart'; 7 import 'package:analysis_server/src/constants.dart';
8 import 'package:analysis_server/src/protocol2.dart' show SourceEdit, 8 import 'package:analysis_server/src/protocol2.dart' show SourceEdit,
9 SourceFileEdit, Position; 9 SourceFileEdit, Position;
10 import 'package:analysis_server/src/services/correction/change.dart'; 10 import 'package:analysis_server/src/services/correction/change.dart';
(...skipping 26 matching lines...) Expand all
37 expect(change.fileEdits, hasLength(1)); 37 expect(change.fileEdits, hasLength(1));
38 { 38 {
39 SourceFileEdit fileEdit = change.getFileEdit('/a.dart'); 39 SourceFileEdit fileEdit = change.getFileEdit('/a.dart');
40 expect(fileEdit, isNotNull); 40 expect(fileEdit, isNotNull);
41 expect(fileEdit.edits, unorderedEquals([edit1, edit2])); 41 expect(fileEdit.edits, unorderedEquals([edit1, edit2]));
42 } 42 }
43 } 43 }
44 44
45 void test_getFileEdit() { 45 void test_getFileEdit() {
46 Change change = new Change('msg'); 46 Change change = new Change('msg');
47 SourceFileEdit fileEdit = new SourceFileEdit('/a.dart', <SourceEdit>[]); 47 SourceFileEdit fileEdit = new SourceFileEdit('/a.dart');
48 change.addFileEdit(fileEdit); 48 change.addFileEdit(fileEdit);
49 expect(change.getFileEdit('/a.dart'), fileEdit); 49 expect(change.getFileEdit('/a.dart'), fileEdit);
50 } 50 }
51 51
52 void test_getFileEdit_empty() { 52 void test_getFileEdit_empty() {
53 Change change = new Change('msg'); 53 Change change = new Change('msg');
54 expect(change.getFileEdit('/some.dart'), isNull); 54 expect(change.getFileEdit('/some.dart'), isNull);
55 } 55 }
56 56
57 void test_toJson() { 57 void test_toJson() {
58 Change change = new Change('msg'); 58 Change change = new Change('msg');
59 change.addFileEdit(new SourceFileEdit('/a.dart', <SourceEdit>[]) 59 change.addFileEdit(new SourceFileEdit('/a.dart')
60 ..add(new SourceEdit(1, 2, 'aaa')) 60 ..add(new SourceEdit(1, 2, 'aaa'))
61 ..add(new SourceEdit(10, 20, 'bbb'))); 61 ..add(new SourceEdit(10, 20, 'bbb')));
62 change.addFileEdit(new SourceFileEdit('/b.dart', <SourceEdit>[]) 62 change.addFileEdit(new SourceFileEdit('/b.dart')
63 ..add(new SourceEdit(21, 22, 'xxx')) 63 ..add(new SourceEdit(21, 22, 'xxx'))
64 ..add(new SourceEdit(210, 220, 'yyy'))); 64 ..add(new SourceEdit(210, 220, 'yyy')));
65 { 65 {
66 var group = new LinkedEditGroup(); 66 var group = new LinkedEditGroup();
67 change.addLinkedEditGroup(group 67 change.addLinkedEditGroup(group
68 ..addPosition(new Position('/ga.dart', 1), 2) 68 ..addPosition(new Position('/ga.dart', 1), 2)
69 ..addPosition(new Position('/ga.dart', 10), 2)); 69 ..addPosition(new Position('/ga.dart', 10), 2));
70 group.addSuggestion( 70 group.addSuggestion(
71 new LinkedEditSuggestion(LinkedEditSuggestionKind.TYPE, 'AA')); 71 new LinkedEditSuggestion(LinkedEditSuggestionKind.TYPE, 'AA'));
72 group.addSuggestion( 72 group.addSuggestion(
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 } 189 }
190 190
191 191
192 @ReflectiveTestCase() 192 @ReflectiveTestCase()
193 class FileEditTest { 193 class FileEditTest {
194 void test_addAll() { 194 void test_addAll() {
195 SourceEdit edit1a = new SourceEdit(1, 0, 'a1'); 195 SourceEdit edit1a = new SourceEdit(1, 0, 'a1');
196 SourceEdit edit1b = new SourceEdit(1, 0, 'a2'); 196 SourceEdit edit1b = new SourceEdit(1, 0, 'a2');
197 SourceEdit edit10 = new SourceEdit(10, 1, 'b'); 197 SourceEdit edit10 = new SourceEdit(10, 1, 'b');
198 SourceEdit edit100 = new SourceEdit(100, 2, 'c'); 198 SourceEdit edit100 = new SourceEdit(100, 2, 'c');
199 SourceFileEdit fileEdit = new SourceFileEdit('/test.dart', <SourceEdit>[]); 199 SourceFileEdit fileEdit = new SourceFileEdit('/test.dart');
200 fileEdit.addAll([edit100, edit1a, edit10, edit1b]); 200 fileEdit.addAll([edit100, edit1a, edit10, edit1b]);
201 expect(fileEdit.edits, [edit100, edit10, edit1b, edit1a]); 201 expect(fileEdit.edits, [edit100, edit10, edit1b, edit1a]);
202 } 202 }
203 203
204 void test_add_sorts() { 204 void test_add_sorts() {
205 SourceEdit edit1a = new SourceEdit(1, 0, 'a1'); 205 SourceEdit edit1a = new SourceEdit(1, 0, 'a1');
206 SourceEdit edit1b = new SourceEdit(1, 0, 'a2'); 206 SourceEdit edit1b = new SourceEdit(1, 0, 'a2');
207 SourceEdit edit10 = new SourceEdit(10, 1, 'b'); 207 SourceEdit edit10 = new SourceEdit(10, 1, 'b');
208 SourceEdit edit100 = new SourceEdit(100, 2, 'c'); 208 SourceEdit edit100 = new SourceEdit(100, 2, 'c');
209 SourceFileEdit fileEdit = new SourceFileEdit('/test.dart', <SourceEdit>[]); 209 SourceFileEdit fileEdit = new SourceFileEdit('/test.dart');
210 fileEdit.add(edit100); 210 fileEdit.add(edit100);
211 fileEdit.add(edit1a); 211 fileEdit.add(edit1a);
212 fileEdit.add(edit1b); 212 fileEdit.add(edit1b);
213 fileEdit.add(edit10); 213 fileEdit.add(edit10);
214 expect(fileEdit.edits, [edit100, edit10, edit1b, edit1a]); 214 expect(fileEdit.edits, [edit100, edit10, edit1b, edit1a]);
215 } 215 }
216 216
217 void test_new() { 217 void test_new() {
218 SourceFileEdit fileEdit = new SourceFileEdit('/test.dart', <SourceEdit>[]); 218 SourceFileEdit fileEdit = new SourceFileEdit('/test.dart');
219 fileEdit.add(new SourceEdit(1, 2, 'aaa')); 219 fileEdit.add(new SourceEdit(1, 2, 'aaa'));
220 fileEdit.add(new SourceEdit(10, 20, 'bbb')); 220 fileEdit.add(new SourceEdit(10, 20, 'bbb'));
221 expect( 221 expect(
222 fileEdit.toString(), 222 fileEdit.toString(),
223 '{"file":"/test.dart","edits":[' 223 '{"file":"/test.dart","edits":['
224 '{"offset":10,"length":20,"replacement":"bbb"},' 224 '{"offset":10,"length":20,"replacement":"bbb"},'
225 '{"offset":1,"length":2,"replacement":"aaa"}]}'); 225 '{"offset":1,"length":2,"replacement":"aaa"}]}');
226 } 226 }
227 227
228 void test_toJson() { 228 void test_toJson() {
229 SourceFileEdit fileEdit = new SourceFileEdit('/test.dart', <SourceEdit>[]); 229 SourceFileEdit fileEdit = new SourceFileEdit('/test.dart');
230 fileEdit.add(new SourceEdit(1, 2, 'aaa')); 230 fileEdit.add(new SourceEdit(1, 2, 'aaa'));
231 fileEdit.add(new SourceEdit(10, 20, 'bbb')); 231 fileEdit.add(new SourceEdit(10, 20, 'bbb'));
232 var expectedJson = { 232 var expectedJson = {
233 FILE: '/test.dart', 233 FILE: '/test.dart',
234 EDITS: [{ 234 EDITS: [{
235 OFFSET: 10, 235 OFFSET: 10,
236 LENGTH: 20, 236 LENGTH: 20,
237 REPLACEMENT: 'bbb' 237 REPLACEMENT: 'bbb'
238 }, { 238 }, {
239 OFFSET: 1, 239 OFFSET: 1,
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
330 330
331 void test_toJson() { 331 void test_toJson() {
332 Position position = new Position('/test.dart', 1); 332 Position position = new Position('/test.dart', 1);
333 var expectedJson = { 333 var expectedJson = {
334 FILE: '/test.dart', 334 FILE: '/test.dart',
335 OFFSET: 1 335 OFFSET: 1
336 }; 336 };
337 expect(position.toJson(), expectedJson); 337 expect(position.toJson(), expectedJson);
338 } 338 }
339 } 339 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698