Change analysis server protocol to omit empty lists when optional.

pkg/analysis_server/test/integration/integration_tests.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.integration.analysis;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:convert';
 import 'dart:io';
@@ skipping 78 matching lines @@
 
   /**
    * Send the server an 'analysis.setAnalysisRoots' command directing it to
    * analyze [sourceDirectory].  If [subscribeStatus] is true (the default),
    * then also enable [SERVER_STATUS] notifications so that [analysisFinished]
    * can be used.
    */
   Future standardAnalysisSetup({bool subscribeStatus: true}) {
     List<Future> futures = <Future>[];
     if (subscribeStatus) {
-      futures.add(sendServerSetSubscriptions(['STATUS']));
+      futures.add(sendServerSetSubscriptions(subscriptions: ['STATUS']));
     }
-    futures.add(sendAnalysisSetAnalysisRoots([sourceDirectory.path], []));
+    futures.add(sendAnalysisSetAnalysisRoots(included: [sourceDirectory.path]));
     return Future.wait(futures);
   }
 
   /**
    * Return a future which will complete when a 'server.status' notification is
    * received from the server with 'analyzing' set to false.
    *
    * The future will only be completed by 'server.status' notifications that are
    * received after this function call.  So it is safe to use this getter
    * multiple times in one test; each time it is used it will wait afresh for
@@ skipping 24 matching lines @@
 
   /**
    * Print out any messages exchanged with the server.  If some messages have
    * already been exchanged with the server, they are printed out immediately.
    */
   void debugStdio() {
     server.debugStdio();
   }
 
   @override
-  Future sendServerSetSubscriptions(List<String> subscriptions, {bool
+  Future sendServerSetSubscriptions({List<String> subscriptions, bool
       checkTypes: true}) {
-    _subscribedToServerStatus = subscriptions.contains('STATUS');
-    return super.sendServerSetSubscriptions(subscriptions, checkTypes:
-        checkTypes);
+    _subscribedToServerStatus = subscriptions != null &&
+        subscriptions.contains('STATUS');
+    return super.sendServerSetSubscriptions(subscriptions: subscriptions,
+        checkTypes: checkTypes);
   }
 
   /**
    * The server is automatically started before every test, and a temporary
    * [sourceDirectory] is created.
    */
   Future setUp() {
     sourceDirectory = Directory.systemTemp.createTempSync('analysisServer');
 
     onAnalysisErrors.listen((params) {
@@ skipping 668 matching lines @@
    */
   void _recordStdio(String line) {
     double elapsedTime = _time.elapsedTicks / _time.frequency;
     line = "$elapsedTime: $line";
     if (_debuggingStdio) {
       print(line);
     }
     _recordedStdio.add(line);
   }
 }