Change analysis server protocol to omit empty lists when optional.

pkg/analysis_server/test/domain_analysis_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.domain.analysis;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/constants.dart';
@@ skipping 32 matching lines @@
     handler = new AnalysisDomainHandler(server);
   });
 
   group('updateContent', testUpdateContent);
   group('setSubscriptions', test_setSubscriptions);
 
   group('AnalysisDomainHandler', () {
     group('setAnalysisRoots', () {
       Response testSetAnalysisRoots(List<String> included,
           List<String> excluded) {
-        Request request = new AnalysisSetAnalysisRootsParams(included,
-            excluded).toRequest('0');
+        Request request = new AnalysisSetAnalysisRootsParams(included: included,
+            excluded: excluded).toRequest('0');
         return handler.handleRequest(request);
       }
 
       group('excluded', () {
         test('excluded folder', () {
           String project = '/project';
           String fileA = '/project/aaa/a.dart';
           String fileB = '/project/bbb/b.dart';
           resourceProvider.newFolder(project);
           resourceProvider.newFile(fileA, '// a');
@@ skipping 26 matching lines @@
           });
         });
       });
     });
 
     group('setPriorityFiles', () {
       test('invalid', () {
         // TODO(paulberry): under the "eventual consistency" model this request
         // should not be invalid.
         var request = new AnalysisSetPriorityFilesParams(
-            ['/project/lib.dart']).toRequest('0');
+            files: ['/project/lib.dart']).toRequest('0');
         var response = handler.handleRequest(request);
         expect(response, isResponseFailure('0'));
       });
 
       test('valid', () {
         resourceProvider.newFolder('/p1');
         resourceProvider.newFile('/p1/a.dart', 'library a;');
         resourceProvider.newFolder('/p2');
         resourceProvider.newFile('/p2/b.dart', 'library b;');
         resourceProvider.newFile('/p2/c.dart', 'library c;');
 
         var setRootsRequest = new AnalysisSetAnalysisRootsParams(
-            ['/p1', '/p2'], []).toRequest('0');
+            included: ['/p1', '/p2']).toRequest('0');
         var setRootsResponse = handler.handleRequest(setRootsRequest);
         expect(setRootsResponse, isResponseSuccess('0'));
 
         void setPriorityFiles(List<String> fileList) {
           var request = new AnalysisSetPriorityFilesParams(
-              fileList).toRequest('0');
+              files: fileList).toRequest('0');
           var response = handler.handleRequest(request);
           expect(response, isResponseSuccess('0'));
           // TODO(brianwilkerson) Enable the line below after getPriorityFiles
           // has been implemented.
           // expect(server.getPriorityFiles(), unorderedEquals(fileList));
         }
 
         setPriorityFiles(['/p1/a.dart', '/p2/b.dart']);
         setPriorityFiles(['/p2/b.dart', '/p2/c.dart']);
         setPriorityFiles([]);
@@ skipping 73 matching lines @@
     AnalysisTestHelper helper = new AnalysisTestHelper();
     String initialContent = 'library A;';
     helper.createSingleFileProject(initialContent);
     return helper.waitForOperationsFinished().then((_) {
       // no errors initially
       List<AnalysisError> errors = helper.getTestErrors();
       expect(errors, isEmpty);
       // Add the file to the cache
       helper.sendContentChange(new AddContentOverlay(initialContent));
       // update code
-      helper.sendContentChange(new ChangeContentOverlay([
+      helper.sendContentChange(new ChangeContentOverlay(edits: [
           new SourceEdit('library '.length, 'A;'.length, 'lib')]));
       // wait, there is an error
       return helper.waitForOperationsFinished().then((_) {
         List<AnalysisError> errors = helper.getTestErrors();
         expect(errors, hasLength(1));
       });
     });
   });
 
   test('change on disk, normal', () {
@@ skipping 251 matching lines @@
 
   void addAnalysisSubscriptionNavigation(String file) {
     addAnalysisSubscription(AnalysisService.NAVIGATION, file);
   }
 
   /**
    * Creates an empty project `/project`.
    */
   void createEmptyProject() {
     resourceProvider.newFolder('/project');
-    Request request = new AnalysisSetAnalysisRootsParams(['/project'],
-        []).toRequest('0');
+    Request request = new AnalysisSetAnalysisRootsParams(
+        included: ['/project']).toRequest('0');
     handleSuccessfulRequest(request);
   }
 
   /**
    * Creates a project with a single Dart file `/project/bin/test.dart` with
    * the given [code].
    */
   void createSingleFileProject(code) {
     this.testCode = _getCodeString(code);
     resourceProvider.newFolder('/project');
     resourceProvider.newFile(testFile, testCode);
-    Request request = new AnalysisSetAnalysisRootsParams(['/project'],
-        []).toRequest('0');
+    Request request = new AnalysisSetAnalysisRootsParams(
+        included: ['/project']).toRequest('0');
     handleSuccessfulRequest(request);
   }
 
   /**
    * Returns the offset of [search] in [testCode].
    * Fails if not found.
    */
   int findOffset(String search) {
     int offset = testCode.indexOf(search);
     expect(offset, isNot(-1));
@@ skipping 97 matching lines @@
     return waitForServerOperationsPerformed(server);
   }
 
   static String _getCodeString(code) {
     if (code is List<String>) {
       code = code.join('\n');
     }
     return code as String;
   }
 }