Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 482503002: DevTools: follow up to r288297, check rvh for being null in all branches. (Closed)

Created:
6 years, 4 months ago by pfeldman
Modified:
6 years, 4 months ago
Reviewers:
vsevik, dgozman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Project:
chromium
Visibility:
Public.

Description

DevTools: follow up to r288297, check rvh for being null in all branches. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290151

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -59 lines) Patch
M content/browser/devtools/render_view_devtools_agent_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler.h View 3 chunks +4 lines, -6 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler.cc View 18 chunks +58 lines, -47 lines 2 comments Download

Messages

Total messages: 10 (0 generated)
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 4 months ago (2014-08-16 08:08:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/482503002/1
6 years, 4 months ago (2014-08-16 08:08:47 UTC) #2
pfeldman
The CQ bit was unchecked by pfeldman@chromium.org
6 years, 4 months ago (2014-08-16 08:10:57 UTC) #3
pfeldman
PTAL
6 years, 4 months ago (2014-08-16 08:31:28 UTC) #4
vsevik
lgtm
6 years, 4 months ago (2014-08-16 09:27:06 UTC) #5
dgozman
lgtm https://codereview.chromium.org/482503002/diff/20001/content/browser/devtools/renderer_overrides_handler.cc File content/browser/devtools/renderer_overrides_handler.cc (right): https://codereview.chromium.org/482503002/diff/20001/content/browser/devtools/renderer_overrides_handler.cc#newcode335 content/browser/devtools/renderer_overrides_handler.cc:335: return command->InternalErrorResponse("Could not connect to view"); typo here ...
6 years, 4 months ago (2014-08-16 10:06:20 UTC) #6
pfeldman
https://codereview.chromium.org/482503002/diff/20001/content/browser/devtools/renderer_overrides_handler.cc File content/browser/devtools/renderer_overrides_handler.cc (right): https://codereview.chromium.org/482503002/diff/20001/content/browser/devtools/renderer_overrides_handler.cc#newcode335 content/browser/devtools/renderer_overrides_handler.cc:335: return command->InternalErrorResponse("Could not connect to view"); I actually made ...
6 years, 4 months ago (2014-08-16 11:12:40 UTC) #7
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 4 months ago (2014-08-16 11:13:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/482503002/20001
6 years, 4 months ago (2014-08-16 11:14:24 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 15:31:44 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (20001) as 290151

Powered by Google App Engine
This is Rietveld 408576698