Chromium Code Reviews
Help | Chromium Project | Sign in
(285)

Issue 4825003: ssl3_PlatformSignHashes should set buf->len to the... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by wtc
Modified:
2 years, 11 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

ssl3_PlatformSignHashes should set buf->len to the
actual signature length rather than the estimated
signature length.

R=rsleevi
BUG=37560, 45369, 62027
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Lint Patch
M net/third_party/nss/ssl/sslplatf.c View 5 chunks +3 lines, -3 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 4
wtc
3 years, 5 months ago #1
Ryan Sleevi
ACK! Good catch. LGTM, although this doesn't really involve #45369, does it?
3 years, 5 months ago #2
wtc
I listed bug 45369 because I also modified the Mac implementation of ssl3_PlatformSignHashes. Is the ...
3 years, 5 months ago #3
Ryan Sleevi
3 years, 5 months ago #4
On 2010/11/12 02:05:36, wtc wrote:
> I listed bug 45369 because I also modified the Mac
> implementation of ssl3_PlatformSignHashes.  Is the
> Mac change not necessary?  I can't find good documentation
> of CSSM_SignData.

Looks like Apple's CSP will update the signature length on return, although it
just sets it to be the same as the key size.

http://www.opensource.apple.com/source/libsecurity_apple_csp/libsecurity_appl...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6