Issue 4825003: ssl3_PlatformSignHashes should set buf->len to the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4825003: ssl3_PlatformSignHashes should set buf->len to the... (Closed)

Created:
10 years, 1 month ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

ssl3_PlatformSignHashes should set buf->len to the actual signature length rather than the estimated signature length. R=rsleevi BUG=37560, 45369, 62027 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65979

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	net/third_party/nss/ssl/sslplatf.c	View		5 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

ACK! Good catch. LGTM, although this doesn't really involve #45369, does it?

10 years, 1 month ago (2010-11-12 01:54:20 UTC) #2

wtc

I listed bug 45369 because I also modified the Mac implementation of ssl3_PlatformSignHashes. Is the ...

10 years, 1 month ago (2010-11-12 02:05:36 UTC) #3

Ryan Sleevi

10 years, 1 month ago (2010-11-12 02:20:21 UTC) #4

On 2010/11/12 02:05:36, wtc wrote:
> I listed bug 45369 because I also modified the Mac
> implementation of ssl3_PlatformSignHashes.  Is the
> Mac change not necessary?  I can't find good documentation
> of CSSM_SignData.

Looks like Apple's CSP will update the signature length on return, although it
just sets it to be the same as the key size.

http://www.opensource.apple.com/source/libsecurity_apple_csp/libsecurity_appl...

Expand Messages | Collapse Messages