Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 48243002: When doing SSA type propagation, refine the receiver after a call. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (revision 29343)
+++ sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (working copy)
@@ -39,13 +39,13 @@
// some patterns useful for type conversion.
new SsaInstructionSimplifier(constantSystem, backend, work),
new SsaTypeConversionInserter(compiler),
+ new SsaRedundantPhiEliminator(),
+ new SsaDeadPhiEliminator(),
new SsaTypePropagator(compiler),
// After type propagation, more instructions can be
// simplified.
new SsaInstructionSimplifier(constantSystem, backend, work),
new SsaCheckInserter(backend, work, context.boundsChecked),
- new SsaRedundantPhiEliminator(),
- new SsaDeadPhiEliminator(),
new SsaInstructionSimplifier(constantSystem, backend, work),
new SsaCheckInserter(backend, work, context.boundsChecked),
new SsaTypePropagator(compiler),
@@ -53,6 +53,9 @@
// interceptors are often in the way of LICM'able instructions.
new SsaDeadCodeEliminator(compiler),
new SsaGlobalValueNumberer(compiler),
+ // After GVN, some instructions might need their type to be
+ // updated because they now have different inputs.
+ new SsaTypePropagator(compiler),
new SsaCodeMotion(),
new SsaValueRangeAnalyzer(compiler, constantSystem, work),
// Previous optimizations may have generated new

Powered by Google App Engine
This is Rietveld 408576698