Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart

Issue 48243002: When doing SSA type propagation, refine the receiver after a call. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart (revision 29343)
+++ sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart (working copy)
@@ -15,16 +15,15 @@
HType computeTypeFromInputTypes(HInvokeDynamic instruction,
Compiler compiler) {
- HType receiverType = instruction.getDartReceiver(compiler).instructionType;
- Selector refined = receiverType.refine(instruction.selector, compiler);
- HType type = new HType.inferredTypeForSelector(refined, compiler);
+ Selector selector = instruction.selector;
+ HType type = new HType.inferredTypeForSelector(selector, compiler);
// TODO(ngeoffray): Because we don't know yet the side effects of
// a JS call, we sometimes know more in the compiler about the
// side effects of an element (for example operator% on the int
// class). We should remove this check once we analyze JS calls.
if (!instruction.useGvn()) {
instruction.sideEffects =
- compiler.world.getSideEffectsOfSelector(refined);
+ compiler.world.getSideEffectsOfSelector(selector);
}
return type;
}

Powered by Google App Engine
This is Rietveld 408576698