Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 482383005: Cast logging: Additional stats for getStats() API. (Closed)

Created:
6 years, 4 months ago by imcheng
Modified:
6 years, 3 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@REAL-NEW-MASTER
Project:
chromium
Visibility:
Public.

Description

Cast logging: Additional stats for getStats() API. Histograms in json format: * capture time * encode time * packet latency * frame latency * playout delay - Duration in ms - first event unix time - last event unix time Also improved ReceiverTimeOffsetEstimatorImpl to re-estimate every 30 seconds to account for unknown amount of clock drift between sender and receiver. BUG=403921 Committed: https://crrev.com/f44ecee406acecee0f5cea4b16bd0e395ffc0108 Cr-Commit-Position: refs/heads/master@{#291873}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -39 lines) Patch
M media/cast/logging/raw_event_subscriber_bundle.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/logging/receiver_time_offset_estimator_impl.h View 3 chunks +11 lines, -1 line 0 comments Download
M media/cast/logging/receiver_time_offset_estimator_impl.cc View 5 chunks +27 lines, -5 lines 0 comments Download
M media/cast/logging/receiver_time_offset_estimator_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/logging/stats_event_subscriber.h View 1 6 chunks +59 lines, -3 lines 0 comments Download
M media/cast/logging/stats_event_subscriber.cc View 1 15 chunks +228 lines, -27 lines 0 comments Download
M media/cast/logging/stats_event_subscriber_unittest.cc View 1 3 chunks +18 lines, -0 lines 0 comments Download
M media/cast/test/sender.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
imcheng
PTAL, thanks!
6 years, 4 months ago (2014-08-22 01:27:35 UTC) #1
Alpha Left Google
Looks pretty good. https://codereview.chromium.org/482383005/diff/1/media/cast/logging/stats_event_subscriber.cc File media/cast/logging/stats_event_subscriber.cc (right): https://codereview.chromium.org/482383005/diff/1/media/cast/logging/stats_event_subscriber.cc#newcode280 media/cast/logging/stats_event_subscriber.cc:280: STAT_ENUM_TO_STRING(DURATION_MS); This seems redundant since we ...
6 years, 4 months ago (2014-08-22 01:49:04 UTC) #2
imcheng
https://codereview.chromium.org/482383005/diff/1/media/cast/logging/stats_event_subscriber.cc File media/cast/logging/stats_event_subscriber.cc (right): https://codereview.chromium.org/482383005/diff/1/media/cast/logging/stats_event_subscriber.cc#newcode280 media/cast/logging/stats_event_subscriber.cc:280: STAT_ENUM_TO_STRING(DURATION_MS); On 2014/08/22 01:49:04, Alpha wrote: > This seems ...
6 years, 4 months ago (2014-08-22 19:14:18 UTC) #3
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 4 months ago (2014-08-25 22:06:07 UTC) #4
Alpha Left Google
lgtm
6 years, 4 months ago (2014-08-25 22:06:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/482383005/20001
6 years, 4 months ago (2014-08-25 22:07:24 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-26 00:50:04 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 01:39:21 UTC) #8
commit-bot: I haz the power
Failed to commit the patch.
6 years, 4 months ago (2014-08-26 01:39:22 UTC) #9
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 4 months ago (2014-08-26 01:46:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/482383005/20001
6 years, 4 months ago (2014-08-26 01:48:28 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 01:50:03 UTC) #12
commit-bot: I haz the power
Failed to commit the patch.
6 years, 4 months ago (2014-08-26 01:50:05 UTC) #13
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 3 months ago (2014-08-26 06:42:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/482383005/40001
6 years, 3 months ago (2014-08-26 06:43:45 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-26 07:42:16 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (40001) as 91ab56fe7a369333cd5569e57c59342c47d4172d
6 years, 3 months ago (2014-08-26 09:12:44 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:41:40 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f44ecee406acecee0f5cea4b16bd0e395ffc0108
Cr-Commit-Position: refs/heads/master@{#291873}

Powered by Google App Engine
This is Rietveld 408576698