Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 482373002: Catch up ruby and its tag omission rule changes in HTML5 CR Feb 2014 (Closed)

Created:
6 years, 4 months ago by yuki.sekiguchi
Modified:
6 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Project:
blink
Visibility:
Public.

Description

Catch up ruby and its tag omission rule changes in HTML5 CR Feb 2014 This CL is based on http://trac.webkit.org/changeset/167437 by Koji Ishii <kojishi@gmail.com>; Fixed an rp element behavior to match with the HTML5 spec which was changed at the following commit: https://github.com/w3c/html/commit/c61397b989b28235ee2228f280aa8d475f3b9ebf html5lib-test was also updated using my pull request: https://github.com/darobin/html5lib-tests/pull/2 Changed expectation of tests19 because it showed number of total test cases. Changed expectation of bidi-override-in-anonymous-block because tag omission rule changed DOM tree structure. The following is description from the original ChangeLog: Catch up ruby and its tag omission rule changes in HTML5 CR Feb 2014 https://bugs.webkit.org/show_bug.cgi?id=131175 Patch by Koji Ishii <kojishi@gmail.com>; on 2014-04-17 Reviewed by Darin Adler. Source/WebCore: Tests: html5lib/resources/ruby.dat html5lib/resources/tests19.dat This patch makes WebKit HTML parser to match to the tag omission rules of HTML5 CR Feb 2014: http://www.w3.org/TR/2014/CR-html5-20140204/syntax.html#syntax-tag-omission with the support for two new elements (rb, rtc) which were also defined in the spec: http://www.w3.org/TR/2014/CR-html5-20140204/text-level-semantics.html#the-rb-element http://www.w3.org/TR/2014/CR-html5-20140204/text-level-semantics.html#the-rtc-element to better support use cases presented by W3C I18N WG: http://www.w3.org/TR/ruby-use-cases/ * html/HTMLTagNames.in: rb and rtc added as HTMLElement interfaces. * html/parser/HTMLConstructionSite.cpp: (WebCore::hasImpliedEndTag): the spec says rb and rtc have implied end tags. * html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): rb and rtc added. rt excludes rtc from its implied end tags. LayoutTests: 25 new test cases in 2 test files imported from pull requests to html5lib-tests, with run- and expected-files generated. All new tests pass with the changes included in this patch. * html5lib/generated/run-ruby-data-expected.txt: Added. * html5lib/generated/run-ruby-data.html: Added (generated by generate-test-wrappers.py) * html5lib/generated/run-ruby-write-expected.txt: Added. * html5lib/generated/run-ruby-write.html: Added (generated by generate-test-wrappers.py) * html5lib/resources/ruby.dat: Added from https://github.com/darobin/html5lib-tests/pull/1 * html5lib/resources/tests19.dat: Updated from https://github.com/html5lib/html5lib-tests/pull/27 BUG=404892 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180523

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed TODO. Used HTMLUnknownElement. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+415 lines, -41 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + LayoutTests/html5lib/generated/run-ruby-data.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/html5lib/generated/run-ruby-data-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/html5lib/generated/run-ruby-write.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/html5lib/generated/run-ruby-write-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/html5lib/generated/run-tests19-data-expected.txt View 5 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/html5lib/generated/run-tests19-write-expected.txt View 5 chunks +5 lines, -5 lines 0 comments Download
A LayoutTests/html5lib/resources/ruby.dat View 1 chunk +298 lines, -0 lines 0 comments Download
M LayoutTests/html5lib/resources/tests19.dat View 1 chunk +59 lines, -0 lines 0 comments Download
M LayoutTests/platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt View 2 chunks +27 lines, -27 lines 0 comments Download
M Source/core/html/HTMLTagNames.in View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
yuki.sekiguchi
Hi tkent, Could you review this?
6 years, 4 months ago (2014-08-19 04:52:21 UTC) #1
tkent
https://codereview.chromium.org/482373002/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/482373002/diff/1/LayoutTests/TestExpectations#newcode391 LayoutTests/TestExpectations:391: crbug.com/TODO fast/css/bidi-override-in-anonymous-block.html [ NeedsRebaseline ] TODO -> 404892 https://codereview.chromium.org/482373002/diff/1/Source/core/html/HTMLTagNames.in ...
6 years, 4 months ago (2014-08-19 05:04:25 UTC) #2
yuki.sekiguchi
On 2014/08/19 05:04:25, tkent wrote: > https://codereview.chromium.org/482373002/diff/1/LayoutTests/TestExpectations > File LayoutTests/TestExpectations (right): > > https://codereview.chromium.org/482373002/diff/1/LayoutTests/TestExpectations#newcode391 > ...
6 years, 4 months ago (2014-08-19 06:48:24 UTC) #3
yuki.sekiguchi
Hi tkent, I fixed your comments. Could you check them?
6 years, 4 months ago (2014-08-19 06:52:37 UTC) #4
tkent
lgtm CL description: > because tag ommission rule changed DOM tree structure. ommission -> omission. ...
6 years, 4 months ago (2014-08-19 06:52:55 UTC) #5
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-19 06:53:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yuki.sekiguchi@access-company.com/482373002/20001
6 years, 4 months ago (2014-08-19 06:53:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (20001) as 180523
6 years, 4 months ago (2014-08-19 06:57:39 UTC) #8
yuki.sekiguchi
6 years, 4 months ago (2014-08-19 07:03:27 UTC) #9
Message was sent while issue was closed.
On 2014/08/19 06:57:39, I haz the power (commit-bot) wrote:
> Committed patchset #2 (20001) as 180523

Thank you!

Powered by Google App Engine
This is Rietveld 408576698