Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 482353002: nss.gyp: Remove two files from sources that were removed in all conditionals. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
wtc
CC:
chromium-reviews
Base URL:
http://src.chromium.org/chrome/trunk/deps/third_party/nss/
Visibility:
Public.

Description

nss: Remove two files from sources that were removed in all conditionals. No functional change, just makes the file a bit less confusing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=290695

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2274 lines) Patch
M nss.gyp View 4 chunks +0 lines, -8 lines 0 comments Download
D nss/lib/freebl/intel-aes-x64-masm.asm View 1 1 chunk +0 lines, -971 lines 0 comments Download
D nss/lib/freebl/intel-gcm-x64-masm.asm View 1 1 chunk +0 lines, -1295 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
It's 64bit asm code. It got removed: * For 32bit builds * For non-Windows: Always ...
6 years, 4 months ago (2014-08-19 01:27:19 UTC) #1
Nico
ping
6 years, 4 months ago (2014-08-19 23:11:02 UTC) #2
wtc
Patch set 1 LGTM. Could you also remove those two files? I added them partly ...
6 years, 4 months ago (2014-08-19 23:11:11 UTC) #3
Nico
On 2014/08/19 23:11:11, wtc wrote: > Patch set 1 LGTM. Could you also remove those ...
6 years, 4 months ago (2014-08-19 23:31:59 UTC) #4
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-19 23:36:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/482353002/20001
6 years, 4 months ago (2014-08-19 23:37:03 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 23:37:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290695

Powered by Google App Engine
This is Rietveld 408576698