Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 482273005: Remove SpeechSynthesis runtime flag (status=stable) (Closed)

Created:
6 years, 4 months ago by heeyoun.lee
Modified:
6 years, 4 months ago
Reviewers:
eseidel
CC:
blink-reviews, kangil_, pdr., tfarina
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove SpeechSynthesis runtime flag (status=stable) BUG=402536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180763

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add WebRuntimeFeatures.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M Source/modules/speech/SpeechSynthesis.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisEvent.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisVoice.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/speech/WindowSpeechSynthesis.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
heeyoun.lee
PTAL
6 years, 4 months ago (2014-08-20 13:32:57 UTC) #1
eseidel
I don't think this patch compiles. https://codereview.chromium.org/482273005/diff/1/Source/web/WebRuntimeFeatures.cpp File Source/web/WebRuntimeFeatures.cpp (left): https://codereview.chromium.org/482273005/diff/1/Source/web/WebRuntimeFeatures.cpp#oldcode210 Source/web/WebRuntimeFeatures.cpp:210: void WebRuntimeFeatures::enableSpeechSynthesis(bool enable) ...
6 years, 4 months ago (2014-08-20 15:57:50 UTC) #2
heeyoun.lee
https://codereview.chromium.org/482273005/diff/1/Source/web/WebRuntimeFeatures.cpp File Source/web/WebRuntimeFeatures.cpp (left): https://codereview.chromium.org/482273005/diff/1/Source/web/WebRuntimeFeatures.cpp#oldcode210 Source/web/WebRuntimeFeatures.cpp:210: void WebRuntimeFeatures::enableSpeechSynthesis(bool enable) On 2014/08/20 15:57:50, eseidel wrote: > ...
6 years, 4 months ago (2014-08-21 07:40:45 UTC) #3
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 4 months ago (2014-08-21 15:24:45 UTC) #4
eseidel
lgtm
6 years, 4 months ago (2014-08-21 15:24:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heeyoun.lee@samsung.com/482273005/20001
6 years, 4 months ago (2014-08-21 15:27:07 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-21 20:27:14 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 21:30:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/8104)
6 years, 4 months ago (2014-08-21 21:30:08 UTC) #9
heeyoun.lee
The CQ bit was checked by heeyoun.lee@samsung.com
6 years, 4 months ago (2014-08-22 08:59:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heeyoun.lee@samsung.com/482273005/20001
6 years, 4 months ago (2014-08-22 09:00:10 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-22 09:03:13 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 09:10:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180763

Powered by Google App Engine
This is Rietveld 408576698