chromeos/test/data/network/shill_output_l2tpipsec.json - Issue 482243002: Use Managed properties for Preferred and Provider.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromeos/test/data/network/shill_output_l2tpipsec.json

Issue 482243002: Use Managed properties for Preferred and Provider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address feedback, fix unittests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 { "GUID": "guid",

	2 "Type": "vpn",

	3 "Name": "MyL2TPVPN",

	4 "Provider": {
	pneubeck (no reviews) 2014/08/20 08:16:16 When can they finally fix this in Shill... maybe I When can they finally fix this in Shill... maybe I should just do it myself, I guess... stevenjb 2014/08/20 17:18:38 Acknowledged. Show quoted text On 2014/08/20 08:16:16, pneubeck wrote: > When can they finally fix this in Shill... maybe I should just do it myself, I > guess... Acknowledged.
	5 "Host": "some.host.org",

	6 "L2TPIPsec.PSK": "some_preshared_key",

	7 "L2TPIPsec.User": "some username",

	8 "L2TPIPsec.XauthPassword": "some xauth password",

	9 "L2TPIPsec.XauthUser": "some xauth username",

	10 "L2TPIPsec.Password": "some password",

	11 "Type": "l2tpipsec",

	12 },

	13 "SaveCredentials": true

	14 }

OLD	NEW