Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 482173003: Revert of linux: Always use (64bit) gold for linking, even on 32bit. (Closed)

Created:
6 years, 3 months ago by noms (inactive)
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang, brettw, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of linux: Always use (64bit) gold for linking, even on 32bit. (patchset #3 of https://codereview.chromium.org/503873004/) Reason for revert: Tentatively reverting because it made the sizes bot grumpy (http://build.chromium.org/p/chromium/buildstatus?builder=Linux&number=52715) Original issue's description: > linux: Always use (64bit) gold for linking, even on 32bit. > > All 32bit bots now have 64bit kernels and can run 64bit gold. So always use > that. We already require running 64bit binaries for clang, and the official > bots already used to do this for gold. This makes linking on 32bit bots faster, > and simplifies our configurations. > > BUG=396333 > TBR=brettw > > Committed: https://chromium.googlesource.com/chromium/src/+/c7864673b16236a2ec3cd435bb11608cbb76c1b4 TBR=thestig@chromium.org,brettw@chromium.org,thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=396333 Committed: https://crrev.com/277720168a1fd1bd3147912fc81c88f6dc0f1c69 Cr-Commit-Position: refs/heads/master@{#291905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M build/common.gypi View 6 chunks +34 lines, -7 lines 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
noms (inactive)
Created Revert of linux: Always use (64bit) gold for linking, even on 32bit.
6 years, 3 months ago (2014-08-26 15:20:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/482173003/1
6 years, 3 months ago (2014-08-26 15:20:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as c37f5c0ba600877ca3475acc1c88c744ed165c2d
6 years, 3 months ago (2014-08-26 15:21:39 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:42:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/277720168a1fd1bd3147912fc81c88f6dc0f1c69
Cr-Commit-Position: refs/heads/master@{#291905}

Powered by Google App Engine
This is Rietveld 408576698