Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/utility/chrome_content_utility_client_unittest.cc

Issue 482163002: Large wallpaper decoding in utility process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer comments, rework DecodeImage() Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/chrome_utility_messages.h"
6 #include "chrome/utility/chrome_content_utility_client.h"
7 #include "ipc/ipc_channel.h"
8 #include "testing/gtest/include/gtest/gtest.h"
9 #include "ui/gfx/codec/jpeg_codec.h"
10
11 namespace {
12
13 bool CreateJPEGImage(int width,
14 int height,
15 SkColor color,
16 std::vector<unsigned char>* output) {
17 SkBitmap bitmap;
18 bitmap.allocN32Pixels(width, height);
19 bitmap.eraseColor(color);
20
21 const int kQuality = 50;
22 if (!gfx::JPEGCodec::Encode(
23 static_cast<const unsigned char*>(bitmap.getPixels()),
24 gfx::JPEGCodec::FORMAT_SkBitmap,
25 width,
26 height,
27 bitmap.rowBytes(),
28 kQuality,
29 output)) {
30 LOG(ERROR) << "Unable to encode " << width << "x" << height << " bitmap";
31 return false;
32 }
33 return true;
34 }
35
36 } // namespace
37
38 typedef testing::Test ChromeContentUtilityClientTest;
39
40 // Test that DecodeImage() doesn't return image message > kMaximumMessageSize
41 TEST_F(ChromeContentUtilityClientTest, DecodeImageSizeLimit) {
42 // Approx max height for 3:2 image that will fit in IPC message;
43 // 1.5 for width/height ratio, 4 for bytes/pixel
44 int max_height_for_msg = sqrt(IPC::Channel::kMaximumMessageSize/(1.5*4));
45 int base_msg_size = sizeof(ChromeUtilityHostMsg_DecodeImage_Succeeded);
46
47 // Sizes which should trigger dimension-halving 0, 1 and 2 times
48 int heights[] = { max_height_for_msg - 20,
49 max_height_for_msg + 20,
50 2 * max_height_for_msg + 20 };
51 int widths[] = { heights[0]*3/2, heights[1]*3/2, heights[2]*3/2 };
52 for (size_t i = 0; i < arraysize(heights); i++) {
53 std::vector<unsigned char> jpg;
54 CreateJPEGImage(widths[i], heights[i], SK_ColorRED, &jpg);
55 SkBitmap bitmap = ChromeContentUtilityClient::DecodeImage(jpg, true);
56
57 // Check that image has been shurnk appropriately
58 EXPECT_EQ(widths[i] >> i, bitmap.width());
59 EXPECT_EQ(heights[i] >> i, bitmap.height());
60 EXPECT_LT(bitmap.computeSize64() + base_msg_size,
61 static_cast<int64_t>(IPC::Channel::kMaximumMessageSize));
62
63 // Check that if resize not requested and image exceeds IPC size limit,
64 // an empty image is returned
65 if (heights[i] > max_height_for_msg) {
66 SkBitmap empty_bmp = ChromeContentUtilityClient::DecodeImage(jpg, false);
67 EXPECT_TRUE(empty_bmp.empty());
68 }
69 }
70 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698