Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/browser/image_decoder.h

Issue 482163002: Large wallpaper decoding in utility process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer comments, rework DecodeImage() Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/webstore_install_helper.cc ('k') | chrome/browser/image_decoder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_IMAGE_DECODER_H_ 5 #ifndef CHROME_BROWSER_IMAGE_DECODER_H_
6 #define CHROME_BROWSER_IMAGE_DECODER_H_ 6 #define CHROME_BROWSER_IMAGE_DECODER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 // Starts asynchronous image decoding. Once finished, the callback will be 46 // Starts asynchronous image decoding. Once finished, the callback will be
47 // posted back to |task_runner|. 47 // posted back to |task_runner|.
48 void Start(scoped_refptr<base::SequencedTaskRunner> task_runner); 48 void Start(scoped_refptr<base::SequencedTaskRunner> task_runner);
49 49
50 const std::vector<unsigned char>& get_image_data() const { 50 const std::vector<unsigned char>& get_image_data() const {
51 return image_data_; 51 return image_data_;
52 } 52 }
53 53
54 void set_delegate(Delegate* delegate) { delegate_ = delegate; } 54 void set_delegate(Delegate* delegate) { delegate_ = delegate; }
55 void set_shrink_to_fit(bool shrink_to_fit) { shrink_to_fit_ = shrink_to_fit; }
55 56
56 private: 57 private:
57 // It's a reference counted object, so destructor is private. 58 // It's a reference counted object, so destructor is private.
58 virtual ~ImageDecoder(); 59 virtual ~ImageDecoder();
59 60
60 // Overidden from UtilityProcessHostClient: 61 // Overidden from UtilityProcessHostClient:
61 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; 62 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
62 63
63 // IPC message handlers. 64 // IPC message handlers.
64 void OnDecodeImageSucceeded(const SkBitmap& decoded_image); 65 void OnDecodeImageSucceeded(const SkBitmap& decoded_image);
65 void OnDecodeImageFailed(); 66 void OnDecodeImageFailed();
66 67
67 // Launches sandboxed process that will decode the image. 68 // Launches sandboxed process that will decode the image.
68 void DecodeImageInSandbox(const std::vector<unsigned char>& image_data); 69 void DecodeImageInSandbox(const std::vector<unsigned char>& image_data);
69 70
70 Delegate* delegate_; 71 Delegate* delegate_;
71 std::vector<unsigned char> image_data_; 72 std::vector<unsigned char> image_data_;
72 const ImageCodec image_codec_; 73 const ImageCodec image_codec_;
73 scoped_refptr<base::SequencedTaskRunner> task_runner_; 74 scoped_refptr<base::SequencedTaskRunner> task_runner_;
75 bool shrink_to_fit_;
sky 2014/09/09 20:19:11 Add a description of this.
Greg Levin 2014/09/16 15:46:36 Done.
74 76
75 DISALLOW_COPY_AND_ASSIGN(ImageDecoder); 77 DISALLOW_COPY_AND_ASSIGN(ImageDecoder);
76 }; 78 };
77 79
78 #endif // CHROME_BROWSER_IMAGE_DECODER_H_ 80 #endif // CHROME_BROWSER_IMAGE_DECODER_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/webstore_install_helper.cc ('k') | chrome/browser/image_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698