Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 48213004: Remove unnecessary dependencies on "ui" target from some other targets. (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Remove unnecessary dependencies on "ui" target from some other targets. BUG=302505 TEST=None, targets built. R=dalecurtis@chromium.org,thestig@chromium.org,ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232399

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : gl_surface_win.cc needs dwmapi.dll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M media/media.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M printing/printing.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/memory_watcher/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M tools/memory_watcher/memory_watcher.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl.gyp View 1 2 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
tfarina
Dale -> media Lei -> printing, tools Ben -> ui
7 years, 1 month ago (2013-10-31 01:35:15 UTC) #1
DaleCurtis
media/ lgtm assuming it passes the trybots.
7 years, 1 month ago (2013-10-31 01:37:14 UTC) #2
Lei Zhang
lgtm for printing/
7 years, 1 month ago (2013-10-31 01:42:36 UTC) #3
Ben Goodger (Google)
lgtm thanks!
7 years, 1 month ago (2013-10-31 16:37:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/48213004/1
7 years, 1 month ago (2013-10-31 17:34:38 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-10-31 18:16:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/48213004/230001
7 years, 1 month ago (2013-10-31 23:28:04 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-01 01:33:52 UTC) #8
tfarina
Ben, I added the references to dwmapi to gl.gyp in order to fix this error: ...
7 years, 1 month ago (2013-11-01 02:31:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/48213004/420001
7 years, 1 month ago (2013-11-01 02:50:52 UTC) #10
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=96226
7 years, 1 month ago (2013-11-01 09:29:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/48213004/420001
7 years, 1 month ago (2013-11-01 12:58:14 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 15:22:45 UTC) #13
Message was sent while issue was closed.
Change committed as 232399

Powered by Google App Engine
This is Rietveld 408576698