Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 482083004: Verify that gclient solution looks correct. (Closed)

Created:
6 years, 4 months ago by Vadim Sh.
Modified:
6 years, 4 months ago
Reviewers:
iannucci
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Verify that gclient solution looks correct. Print big nagging warning (everytime gclient hooks run) if gclient solution is not configured to use unmanaged git workflow. Also stop uploading reports on Oct 1. We don't want to keep appengine app online forever. R=iannucci@chromium.org BUG=404747 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290430

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -447 lines) Patch
A + tools/check_git_config.py View 14 chunks +94 lines, -27 lines 1 comment Download
D tools/check_git_push_access.py View 1 chunk +0 lines, -420 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vadim Sh.
ptal https://codereview.chromium.org/482083004/diff/1/tools/check_git_config.py File tools/check_git_config.py (right): https://codereview.chromium.org/482083004/diff/1/tools/check_git_config.py#newcode154 tools/check_git_config.py:154: return sol.get('url'), sol.get('deps_file'), sol.get('managed') I intentionally skip custom_deps ...
6 years, 4 months ago (2014-08-18 23:29:22 UTC) #1
iannucci
lgtm
6 years, 4 months ago (2014-08-19 00:26:00 UTC) #2
Vadim Sh.
The CQ bit was checked by vadimsh@chromium.org
6 years, 4 months ago (2014-08-19 00:26:16 UTC) #3
Vadim Sh.
The CQ bit was unchecked by vadimsh@chromium.org
6 years, 4 months ago (2014-08-19 00:26:20 UTC) #4
Vadim Sh.
The CQ bit was checked by vadimsh@chromium.org
6 years, 4 months ago (2014-08-19 00:27:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimsh@chromium.org/482083004/1
6 years, 4 months ago (2014-08-19 00:29:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 290430
6 years, 4 months ago (2014-08-19 00:38:02 UTC) #7
Sami
6 years, 4 months ago (2014-08-20 10:35:35 UTC) #8
Message was sent while issue was closed.
Looks like this check doesn't like the Clank workflow:
https://code.google.com/p/chromium/issues/detail?id=405475. I'm not sure if the
workflow or check is wrong :)

Powered by Google App Engine
This is Rietveld 408576698