Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 482063005: Allow paint invalidation containers to cross frame boundaries. (re-land #2) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Made it work with position:fixed. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index 0050490fac93682abca0ce862b18eb53473cb280..3240740cdabbec631bf2ea27ff118c0aabdafb95 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -975,14 +975,14 @@ void FrameView::layout(bool allowSubtree)
// See http://crbug.com/306706
void FrameView::invalidateTreeIfNeeded()
{
- RenderObject* rootForPaintInvalidation = renderView();
- ASSERT(!rootForPaintInvalidation->needsLayout());
+ RenderView& rootForPaintInvalidation = *renderView();
+ ASSERT(!rootForPaintInvalidation.needsLayout());
- TRACE_EVENT1("blink", "FrameView::invalidateTree", "root", rootForPaintInvalidation->debugName().ascii());
+ TRACE_EVENT1("blink", "FrameView::invalidateTree", "root", rootForPaintInvalidation.debugName().ascii());
- PaintInvalidationState rootPaintInvalidationState(*rootForPaintInvalidation);
+ PaintInvalidationState rootPaintInvalidationState(rootForPaintInvalidation);
- rootForPaintInvalidation->invalidateTreeIfNeeded(rootPaintInvalidationState);
+ rootForPaintInvalidation.invalidateTreeIfNeeded(rootPaintInvalidationState);
// Invalidate the paint of the frameviews scrollbars if needed
if (hasVerticalBarDamage())
@@ -1612,7 +1612,7 @@ HostWindow* FrameView::hostWindow() const
void FrameView::contentRectangleForPaintInvalidation(const IntRect& r)
{
ASSERT(paintInvalidationIsAllowed());
- ASSERT(!m_frame->owner());
+ ASSERT(!m_frame->ownerRenderer());
if (m_isTrackingPaintInvalidations) {
IntRect paintInvalidationRect = r;

Powered by Google App Engine
This is Rietveld 408576698