Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: Source/core/rendering/RenderLayerRepainter.cpp

Issue 482063005: Allow paint invalidation containers to cross frame boundaries. (re-land #2) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/PaintInvalidationState.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderLayerRepainter.cpp
diff --git a/Source/core/rendering/RenderLayerRepainter.cpp b/Source/core/rendering/RenderLayerRepainter.cpp
index d885c7b38f59a36b863bfebedf941558db8fe969..481dc1dbf47752d864a804062bc8e87a4a7d734f 100644
--- a/Source/core/rendering/RenderLayerRepainter.cpp
+++ b/Source/core/rendering/RenderLayerRepainter.cpp
@@ -110,23 +110,7 @@ void RenderLayerRepainter::setBackingNeedsPaintInvalidationInRect(const LayoutRe
// https://bugs.webkit.org/show_bug.cgi?id=61159 describes an unreproducible crash here,
// so assert but check that the layer is composited.
ASSERT(m_renderer.compositingState() != NotComposited);
- if (m_renderer.compositingState() == NotComposited) {
- // If we're trying to issue paint invalidations of the placeholder document layer, propagate the
- // paint invalidation to the native view system.
- LayoutRect absRect(r);
- LayoutPoint delta;
- m_renderer.layer()->convertToLayerCoords(m_renderer.layer()->root(), delta);
- absRect.moveBy(delta);
-
- if (absRect.isEmpty())
- return;
-
- RenderView* view = m_renderer.view();
- if (view)
- view->invalidatePaintForRectangle(absRect);
- return;
- }
- // FIXME: generalize accessors to backing GraphicsLayers so that this code is squasphing-agnostic.
+ // FIXME: generalize accessors to backing GraphicsLayers so that this code is squashing-agnostic.
if (m_renderer.layer()->groupedMapping()) {
LayoutRect paintInvalidationRect = r;
paintInvalidationRect.move(m_renderer.layer()->subpixelAccumulation());
« no previous file with comments | « Source/core/rendering/PaintInvalidationState.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698