Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_path_dependency_test.dart

Issue 482053002: Precompile dependencies' executables for use with "pub run". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Make our SDK version file match the SDK's. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_path_dependency_test.dart
diff --git a/sdk/lib/_internal/pub/test/run/runs_the_script_in_checked_mode_test.dart b/sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_path_dependency_test.dart
similarity index 51%
copy from sdk/lib/_internal/pub/test/run/runs_the_script_in_checked_mode_test.dart
copy to sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_path_dependency_test.dart
index fd6b27af9c707a69623fa08f72982d0ecb4f3492..5c1b1c48e1854f6383202e2d4fcf197888ef7135 100644
--- a/sdk/lib/_internal/pub/test/run/runs_the_script_in_checked_mode_test.dart
+++ b/sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_path_dependency_test.dart
@@ -2,29 +2,28 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+library pub_tests;
+
+import 'package:path/path.dart' as p;
import 'package:scheduled_test/scheduled_test.dart';
import '../descriptor.dart' as d;
import '../test_pub.dart';
-const SCRIPT = """
-main() {
- int a = true;
-}
-""";
-
main() {
initConfig();
- integration('runs the script in checked mode by default', () {
- d.dir(appPath, [
- d.appPubspec(),
+ integration("doesn't create a snapshot for a path dependency", () {
+ d.dir("foo", [
+ d.libPubspec("foo", "1.2.3"),
d.dir("bin", [
- d.file("script.dart", SCRIPT)
+ d.dir("bin", [d.file("hello.dart", "void main() => print('hello!');")])
])
]).create();
- schedulePub(args: ["run", "script"],
- error: contains("'bool' is not a subtype of type 'int' of 'a'"),
- exitCode: 255);
+ d.appDir({"foo": {"path": "../foo"}}).create();
+
+ pubGet();
+
+ d.nothing(p.join(appPath, '.pub', 'bin')).validate();
});
}

Powered by Google App Engine
This is Rietveld 408576698