Force failing CHECK/DCHECKs to end the process on Windows....

base/test/test_suite.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TEST_SUITE_H_
 #define BASE_TEST_SUITE_H_
 
 // Defines a basic test suite framework for running gtest based tests.  You can
 // instantiate this class in your main function and call its Run method to run
 // any gtest based tests that are linked into your executable.
@@ skipping 40 matching lines @@
 
 class TestSuite {
  public:
   TestSuite(int argc, char** argv) {
     base::EnableTerminationOnHeapCorruption();
     CommandLine::Init(argc, argv);
     testing::InitGoogleTest(&argc, argv);
 #if defined(OS_LINUX)
     g_thread_init(NULL);
     gtk_init_check(&argc, &argv);
-#endif
+#endif  // defined(OS_LINUX)
     // Don't add additional code to this constructor.  Instead add it to
     // Initialize().  See bug 6436.
   }
 
   virtual ~TestSuite() {
     CommandLine::Reset();
   }
 
   // Returns true if a string starts with FLAKY_.
   static bool IsFlaky(const char* name) {
@@ skipping 67 matching lines @@
     // objects (such as NotificationService::current()) that Cocoa
     // objects use to remove themselves as observers.
     scoped_pool.Recycle();
 
     Shutdown();
 
     return result;
   }
 
  protected:
-  // All fatal log messages (e.g. DCHECK failures) imply unit test failures.
+#if defined(OS_WIN)
+  // TODO(phajdan.jr): Clean up the windows-specific hacks.
+  // See http://crbug.com/29997
+
+  // By default, base::LogMessage::~LogMessage calls DebugUtil::BreakDebugger()

[M-A Ruel, 2009/12/10 18:49:35]

Thanks for the doc.

+  // when severity is LOG_FATAL. On Windows, this results in error dialogs
+  // which are not friendly to buildbots.
+  // To avoid these problems, we override the LogMessage behaviour by
+  // replacing the assert handler with UnitTestAssertHandler.
   static void UnitTestAssertHandler(const std::string& str) {
+    // FAIL is a googletest macro, it marks the current test as failed.
+    // If throw_on_failure is set to true, it also ends the process.
+    ::testing::FLAGS_gtest_throw_on_failure = true;
     FAIL() << str;
   }
 
-#if defined(OS_WIN)
   // Disable crash dialogs so that it doesn't gum up the buildbot
   virtual void SuppressErrorDialogs() {
     UINT new_flags = SEM_FAILCRITICALERRORS |
                      SEM_NOGPFAULTERRORBOX |
                      SEM_NOOPENFILEERRORBOX;
 
     // Preserve existing error mode, as discussed at
     // http://blogs.msdn.com/oldnewthing/archive/2004/07/27/198410.aspx
     UINT existing_flags = SetErrorMode(new_flags);
     SetErrorMode(existing_flags | new_flags);
   }
-#endif
+#endif  // defined(OS_WIN)
 
   // Override these for custom initialization and shutdown handling.  Use these
   // instead of putting complex code in your constructor/destructor.
 
   virtual void Initialize() {
     // Initialize logging.
     FilePath exe;
     PathService::Get(base::FILE_EXE, &exe);
     FilePath log_filename = exe.ReplaceExtension(FILE_PATH_LITERAL("log"));
     logging::InitLogging(log_filename.value().c_str(),
@@ skipping 36 matching lines @@
 
   virtual void Shutdown() {
   }
 
   // Make sure that we setup an AtExitManager so Singleton objects will be
   // destroyed.
   base::AtExitManager at_exit_manager_;
 };
 
 #endif  // BASE_TEST_SUITE_H_