Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 481943002: Fix Android platform self-tests (Closed)

Created:
6 years, 4 months ago by borenet
Modified:
6 years, 2 months ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix Android platform self-tests Remove things related to no-longer-existing unittests, run makefile_writer_tests --rebaseline BUG=skia:2843 Committed: https://skia.googlesource.com/skia/+/dc0fcbb925c3642dde6ac647666fc04142e713ae

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M platform_tools/android/tests/expectations/Android.mk View 2 chunks +1 line, -4 lines 4 comments Download
M platform_tools/android/tests/gyp_to_android_tests.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
borenet
https://codereview.chromium.org/481943002/diff/1/platform_tools/android/tests/expectations/Android.mk File platform_tools/android/tests/expectations/Android.mk (left): https://codereview.chromium.org/481943002/diff/1/platform_tools/android/tests/expectations/Android.mk#oldcode153 platform_tools/android/tests/expectations/Android.mk:153: include $(BASE_PATH)/bench/Android.mk I don't know why this was removed ...
6 years, 4 months ago (2014-08-18 14:06:28 UTC) #1
djsollen
lgtm https://codereview.chromium.org/481943002/diff/1/platform_tools/android/tests/expectations/Android.mk File platform_tools/android/tests/expectations/Android.mk (left): https://codereview.chromium.org/481943002/diff/1/platform_tools/android/tests/expectations/Android.mk#oldcode153 platform_tools/android/tests/expectations/Android.mk:153: include $(BASE_PATH)/bench/Android.mk On 2014/08/18 14:06:28, borenet wrote: > ...
6 years, 4 months ago (2014-08-18 14:08:23 UTC) #2
borenet
The CQ bit was checked by borenet@google.com
6 years, 4 months ago (2014-08-18 14:09:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/481943002/1
6 years, 4 months ago (2014-08-18 14:10:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (1) as dc0fcbb925c3642dde6ac647666fc04142e713ae
6 years, 4 months ago (2014-08-18 15:13:16 UTC) #5
scroggo
6 years, 2 months ago (2014-10-14 21:27:13 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/481943002/diff/1/platform_tools/android/tests...
File platform_tools/android/tests/expectations/Android.mk (right):

https://codereview.chromium.org/481943002/diff/1/platform_tools/android/tests...
platform_tools/android/tests/expectations/Android.mk:36: LOCAL_FDO_SUPPORT :=
true
On 2014/08/18 14:06:28, borenet wrote:
> No idea what this means; it was added when I ran --rebaseline.

FYI:

Generated by the change in https://codereview.chromium.org/420803003

I think this feature is currently not being used, but we began work on it.

Powered by Google App Engine
This is Rietveld 408576698