Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 481933002: DevTools: fix script_formatter_worker build procedure (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: fix script_formatter_worker build procedure The patch adds missing inputs to the script_formatter_worker module target. R=apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180462

Patch Set 1 #

Total comments: 4

Patch Set 2 : address @apavlov comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M Source/devtools/BUILD.gn View 1 2 chunks +4 lines, -2 lines 0 comments Download
M Source/devtools/devtools.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/devtools.gypi View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lushnikov
ptal
6 years, 4 months ago (2014-08-18 13:21:24 UTC) #1
apavlov
https://codereview.chromium.org/481933002/diff/1/Source/devtools/BUILD.gn File Source/devtools/BUILD.gn (right): https://codereview.chromium.org/481933002/diff/1/Source/devtools/BUILD.gn#newcode295 Source/devtools/BUILD.gn:295: imported_files = gypi_values.devtools_uglify_files + gypi_values.devtools_script_formatter_worker_js_files Please wrap to 80 ...
6 years, 4 months ago (2014-08-18 13:23:18 UTC) #2
lushnikov
https://codereview.chromium.org/481933002/diff/1/Source/devtools/BUILD.gn File Source/devtools/BUILD.gn (right): https://codereview.chromium.org/481933002/diff/1/Source/devtools/BUILD.gn#newcode295 Source/devtools/BUILD.gn:295: imported_files = gypi_values.devtools_uglify_files + gypi_values.devtools_script_formatter_worker_js_files On 2014/08/18 13:23:17, apavlov ...
6 years, 4 months ago (2014-08-18 13:27:08 UTC) #3
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 4 months ago (2014-08-18 13:29:18 UTC) #4
apavlov
lgtm
6 years, 4 months ago (2014-08-18 13:29:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/481933002/20001
6 years, 4 months ago (2014-08-18 13:30:47 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 14:28:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180462

Powered by Google App Engine
This is Rietveld 408576698