Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

Issue 481913005: gpu: glCopyTextureCHROMIUM() checks dest internal format incorrectly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Build fix on clang Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Name 1 Name
2 2
3 CHROMIUM_copy_texture 3 CHROMIUM_copy_texture
4 4
5 Name Strings 5 Name Strings
6 6
7 GL_CHROMIUM_copy_texture 7 GL_CHROMIUM_copy_texture
8 8
9 Version 9 Version
10 10
(...skipping 30 matching lines...) Expand all
41 GLint internal_format, GLenum dest_type) 41 GLint internal_format, GLenum dest_type)
42 42
43 Copies the contents of texture referred to by <source_id> to texture 43 Copies the contents of texture referred to by <source_id> to texture
44 <dest_id>. 44 <dest_id>.
45 45
46 Texture level 0 is copied from the source image to level <level> of the 46 Texture level 0 is copied from the source image to level <level> of the
47 destination texture. The level parameter must be 0 at present. 47 destination texture. The level parameter must be 0 at present.
48 48
49 The internal format of the destination texture is converted to that 49 The internal format of the destination texture is converted to that
50 specified by <internal_format>. Must be one of the following symbolic 50 specified by <internal_format>. Must be one of the following symbolic
51 constants: GL_ALPHA, GL_LUMINANCE, GL_LUMINANCE_ALPHA, GL_RGB, GL_RGBA 51 constants: GL_RGB, GL_RGBA
52 The internal format of <source_id> texture must be one of the following
53 symbolic constants: GL_ALPHA, GL_LUMINANCE, GL_LUMINANCE_ALPHA, GL_RGB,
54 GL_RGBA, GL_BGRA_EXT
52 When <source_id> texture doens't contain a superset of the component 55 When <source_id> texture doens't contain a superset of the component
53 required by <internal_format>, fill the components by following rules. 56 required by <internal_format>, fill the components by following rules.
54 57
55 source format color components 58 source format color components
56 ================================================= 59 =================================================
57 GL_ALPHA (0, 0, 0, A) 60 GL_ALPHA (0, 0, 0, A)
58 GL_LUMINANCE (L, L, L, 1) 61 GL_LUMINANCE (L, L, L, 1)
59 GL_LUMINANCE_ALPHA (L, L, L, A) 62 GL_LUMINANCE_ALPHA (L, L, L, A)
60 GL_RGB (R, G, B, 1) 63 GL_RGB (R, G, B, 1)
61 GL_RGBA (R, G, B, A) 64 GL_RGBA (R, G, B, A)
65 GL_BGRA_EXT (R, G, B, A)
62 66
63 The format type of the destination texture is converted to that specified 67 The format type of the destination texture is converted to that specified
64 by <dest_type>. 68 by <dest_type>.
65 69
66 <target> uses the same parameters as TexImage2D. 70 <target> uses the same parameters as TexImage2D.
67 71
72 INVALID_OPERATION is generated if <internal_format> is not one of the valid formats
73 described above.
74
75 INVALID_OPERATION is generated if the internal format of <source_id> is not one of
76 formats from the table above.
77
68 INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D. 78 INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D.
69 79
70 INVALID_VALUE is generated if <source_id> or <dest_id> are not valid texture 80 INVALID_VALUE is generated if <source_id> or <dest_id> are not valid texture
71 objects. 81 objects.
72 82
73 INVALID_VALUE is generated if textures corresponding to <dest_id> have not 83 INVALID_VALUE is generated if textures corresponding to <dest_id> have not
74 been bound as GL_TEXTURE_2D object. 84 been bound as GL_TEXTURE_2D object.
75 85
76 INVALID_VALUE is generated if textures corresponding to <source_id> have not 86 INVALID_VALUE is generated if textures corresponding to <source_id> have not
77 been bound as GL_TEXTURE_2D, GL_TEXTURE_RECTANGLE_ARB or 87 been bound as GL_TEXTURE_2D, GL_TEXTURE_RECTANGLE_ARB or
(...skipping 12 matching lines...) Expand all
90 100
91 New State 101 New State
92 102
93 None. 103 None.
94 104
95 Revision History 105 Revision History
96 106
97 8/1/2011 Documented the extension 107 8/1/2011 Documented the extension
98 7/4/2013 Add a new parameter dest_type to glCopyTextureCHROMIUM() 108 7/4/2013 Add a new parameter dest_type to glCopyTextureCHROMIUM()
99 16/7/2014 Add GL_TEXTURE_RECTANGLE_ARB as valid source_id target. 109 16/7/2014 Add GL_TEXTURE_RECTANGLE_ARB as valid source_id target.
OLDNEW
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698