Chromium Code Reviews Chromium Code Reviews
Issue 481913005:
gpu: glCopyTextureCHROMIUM() checks dest internal format incorrectly. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 Name | 1 Name |
| 2 | 2 |
| 3 CHROMIUM_copy_texture | 3 CHROMIUM_copy_texture |
| 4 | 4 |
| 5 Name Strings | 5 Name Strings |
| 6 | 6 |
| 7 GL_CHROMIUM_copy_texture | 7 GL_CHROMIUM_copy_texture |
| 8 | 8 |
| 9 Version | 9 Version |
| 10 | 10 |
| (...skipping 30 matching lines...) Expand all Loading... | |
| 41 GLint internal_format, GLenum dest_type) | 41 GLint internal_format, GLenum dest_type) |
| 42 | 42 |
| 43 Copies the contents of texture referred to by <source_id> to texture | 43 Copies the contents of texture referred to by <source_id> to texture |
| 44 <dest_id>. | 44 <dest_id>. |
| 45 | 45 |
| 46 Texture level 0 is copied from the source image to level <level> of the | 46 Texture level 0 is copied from the source image to level <level> of the |
| 47 destination texture. The level parameter must be 0 at present. | 47 destination texture. The level parameter must be 0 at present. |
| 48 | 48 |
| 49 The internal format of the destination texture is converted to that | 49 The internal format of the destination texture is converted to that |
| 50 specified by <internal_format>. Must be one of the following symbolic | 50 specified by <internal_format>. Must be one of the following symbolic |
| 51 constants: GL_ALPHA, GL_LUMINANCE, GL_LUMINANCE_ALPHA, GL_RGB, GL_RGBA | 51 constants: GL_RGB, GL_RGBA |
| 52 The internal format of <source_id> texture must be one of the following | |
| 53 symbolic constants: GL_ALPHA, GL_LUMINANCE, GL_LUMINANCE_ALPHA, GL_RGB, | |
| 54 GL_RGBA, GL_BGRA_EXT | |
| 52 When <source_id> texture doens't contain a superset of the component | 55 When <source_id> texture doens't contain a superset of the component |
| 53 required by <internal_format>, fill the components by following rules. | 56 required by <internal_format>, fill the components by following rules. |
| 54 | 57 |
| 55 source format color components | 58 source format color components |
| 56 ================================================= | 59 ================================================= |
| 57 GL_ALPHA (0, 0, 0, A) | 60 GL_ALPHA (0, 0, 0, A) |
| 58 GL_LUMINANCE (L, L, L, 1) | 61 GL_LUMINANCE (L, L, L, 1) |
| 59 GL_LUMINANCE_ALPHA (L, L, L, A) | 62 GL_LUMINANCE_ALPHA (L, L, L, A) |
| 60 GL_RGB (R, G, B, 1) | 63 GL_RGB (R, G, B, 1) |
| 61 GL_RGBA (R, G, B, A) | 64 GL_RGBA (R, G, B, A) |
| 65 GL_BGRA_EXT (R, G, B, A) | |
| 62 | 66 |
| 63 The format type of the destination texture is converted to that specified | 67 The format type of the destination texture is converted to that specified |
| 64 by <dest_type>. | 68 by <dest_type>. |
| 65 | 69 |
| 66 <target> uses the same parameters as TexImage2D. | 70 <target> uses the same parameters as TexImage2D. |
| 67 | 71 |
|
no sievers
2014/08/22 18:07:19
INVALID_xxx is generated if <internal_format> is n
dshwang
2014/08/22 19:07:54
Thank you! GL_INVALID_OPERATION is proper because
| |
| 68 INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D. | 72 INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D. |
| 69 | 73 |
| 70 INVALID_VALUE is generated if <source_id> or <dest_id> are not valid texture | 74 INVALID_VALUE is generated if <source_id> or <dest_id> are not valid texture |
| 71 objects. | 75 objects. |
| 72 | 76 |
| 73 INVALID_VALUE is generated if textures corresponding to <dest_id> have not | 77 INVALID_VALUE is generated if textures corresponding to <dest_id> have not |
| 74 been bound as GL_TEXTURE_2D object. | 78 been bound as GL_TEXTURE_2D object. |
| 75 | 79 |
| 76 INVALID_VALUE is generated if textures corresponding to <source_id> have not | 80 INVALID_VALUE is generated if textures corresponding to <source_id> have not |
| 77 been bound as GL_TEXTURE_2D, GL_TEXTURE_RECTANGLE_ARB or | 81 been bound as GL_TEXTURE_2D, GL_TEXTURE_RECTANGLE_ARB or |
| (...skipping 12 matching lines...) Expand all Loading... | |
| 90 | 94 |
| 91 New State | 95 New State |
| 92 | 96 |
| 93 None. | 97 None. |
| 94 | 98 |
| 95 Revision History | 99 Revision History |
| 96 | 100 |
| 97 8/1/2011 Documented the extension | 101 8/1/2011 Documented the extension |
| 98 7/4/2013 Add a new parameter dest_type to glCopyTextureCHROMIUM() | 102 7/4/2013 Add a new parameter dest_type to glCopyTextureCHROMIUM() |
| 99 16/7/2014 Add GL_TEXTURE_RECTANGLE_ARB as valid source_id target. | 103 16/7/2014 Add GL_TEXTURE_RECTANGLE_ARB as valid source_id target. |
| OLD | NEW |
