Issue 481903002: [turbofan] Support lowering of ChangeFloat64ToTagged/ChangeTaggedToInt32.

Issue 481903002: [turbofan] Support lowering of ChangeFloat64ToTagged/ChangeTaggedToInt32. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer

Modified:
6 years, 4 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Support lowering of ChangeFloat64ToTagged/ChangeTaggedToInt32. Adds new ValueEffect operator to ensure proper scheduling of AllocateHeapNumber call nodes. Also includes some refactoring to reduce code duplication. TEST=compiler-unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23175

Patch Set 1 #

Total comments: 2

Patch Set 2 : REBASE and refactor ChangeLoweringTest to not use templates. #

Patch Set 3 : Add comment about context for AllocateHeapNumber. #

Patch Set 4 : GCC fix...again #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+325 lines, -117 lines)			Patch
M	src/compiler/change-lowering.h	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/compiler/change-lowering.cc	View	1 2	3 chunks	+67 lines, -25 lines	0 comments	Download
M	src/compiler/common-operator.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/compiler/opcodes.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/operator-properties-inl.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/typer.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	test/compiler-unittests/change-lowering-unittest.cc	View	1 2 3	8 chunks	+205 lines, -89 lines	0 comments	Download
M	test/compiler-unittests/common-operator-unittest.cc	View		2 chunks	+15 lines, -1 line	0 comments	Download
M	test/compiler-unittests/compiler-unittests.h	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	test/compiler-unittests/graph-unittest.h	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download
M	test/compiler-unittests/graph-unittest.cc	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jarin

lgtm https://codereview.chromium.org/481903002/diff/1/src/compiler/change-lowering.cc File src/compiler/change-lowering.cc (right): https://codereview.chromium.org/481903002/diff/1/src/compiler/change-lowering.cc#newcode183 src/compiler/change-lowering.cc:183: Node* context = jsgraph()->SmiConstant(0); Please add a comment ...

6 years, 4 months ago (2014-08-19 04:38:52 UTC) #2

Benedikt Meurer

https://codereview.chromium.org/481903002/diff/1/src/compiler/change-lowering.cc File src/compiler/change-lowering.cc (right): https://codereview.chromium.org/481903002/diff/1/src/compiler/change-lowering.cc#newcode183 src/compiler/change-lowering.cc:183: Node* context = jsgraph()->SmiConstant(0); On 2014/08/19 04:38:52, jarin wrote: ...

6 years, 4 months ago (2014-08-19 04:44:50 UTC) #3

Benedikt Meurer

6 years, 4 months ago (2014-08-19 04:54:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as 23175 (tree was closed).

Expand Messages | Collapse Messages