Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 481883003: Rebaseline astcbitmap and etc1bitmap on Recipes bot (Closed)

Created:
6 years, 4 months ago by borenet
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Rebaseline astcbitmap and etc1bitmap on Recipes bot BUG=skia:761 NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/de512d9a6cbbc5327521b65d06125810009f3dc1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M expectations/gm/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Recipes/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
borenet
The new images look blurry compared to the old - is that expected?
6 years, 4 months ago (2014-08-18 12:30:36 UTC) #1
robertphillips
lgtm. These tests underwent a large rebaseline in (Rebaseline R11 and ASTC bitmap GMs https://codereview.chromium.org/471723002). ...
6 years, 4 months ago (2014-08-18 12:43:59 UTC) #2
borenet
On 2014/08/18 12:43:59, robertphillips wrote: > lgtm. These tests underwent a large rebaseline in (Rebaseline ...
6 years, 4 months ago (2014-08-18 12:45:06 UTC) #3
borenet
The CQ bit was checked by borenet@google.com
6 years, 4 months ago (2014-08-18 12:45:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/481883003/1
6 years, 4 months ago (2014-08-18 12:45:42 UTC) #5
robertphillips
I take that back. It actually appears some baselines for the pdf config were added ...
6 years, 4 months ago (2014-08-18 12:45:56 UTC) #6
borenet
The CQ bit was unchecked by borenet@google.com
6 years, 4 months ago (2014-08-18 13:50:04 UTC) #7
borenet
The CQ bit was checked by borenet@google.com
6 years, 4 months ago (2014-08-18 13:50:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/481883003/1
6 years, 4 months ago (2014-08-18 13:50:29 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 13:50:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (1) as de512d9a6cbbc5327521b65d06125810009f3dc1

Powered by Google App Engine
This is Rietveld 408576698