athena: Fix window-layout in split-view mode.

athena: Fix window-layout in split-view mode.

. When a window is hidden while in split-view mode, do not resize all the windows
  to the container size.
. When a new window shows up while in split-view mode, make sure the window is
  sized correctly (currently always get the size of the left-split).

BUG=383421, 403945
R=oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290330

[sadrul, 2014-08-18 05:30:05]

https://codereview.chromium.org/481843002/diff/20001/athena/wm/window_manager...
File athena/wm/window_manager_impl.h (right):

https://codereview.chromium.org/481843002/diff/20001/athena/wm/window_manager...
athena/wm/window_manager_impl.h:43: friend class AthenaContainerLayoutManager;
An alternative to this is to expose some of the internals via API.

[oshima, 2014-08-18 16:13:03]

https://codereview.chromium.org/481843002/diff/100001/athena/wm/window_manage...
File athena/wm/window_manager_impl.cc (right):

https://codereview.chromium.org/481843002/diff/100001/athena/wm/window_manage...
athena/wm/window_manager_impl.cc:58: const aura::Window::Windows& list =
instance->container_->children();
can we use WindowListProvider::GetWindowList ?

I'd like to keep the logic to tell which windows are activity in one place.

https://codereview.chromium.org/481843002/diff/100001/athena/wm/window_manage...
athena/wm/window_manager_impl.cc:59: const gfx::Size container_size =
instance->container_->bounds().size();
gfx::Screen::GetPrimaryDisplay().work_area()

https://codereview.chromium.org/481843002/diff/100001/athena/wm/window_manage...
athena/wm/window_manager_impl.cc:62: if (is_splitview) {
I think it's better to let SplitViewController layout windows
instead. WDTY?

https://codereview.chromium.org/481843002/diff/100001/athena/wm/window_manage...
athena/wm/window_manager_impl.cc:90: return;
how about checking if the child window is in window list instead?

[sadrul, 2014-08-18 16:45:43]

https://codereview.chromium.org/481843002/diff/100001/athena/wm/window_manage...
File athena/wm/window_manager_impl.cc (right):

https://codereview.chromium.org/481843002/diff/100001/athena/wm/window_manage...
athena/wm/window_manager_impl.cc:58: const aura::Window::Windows& list =
instance->container_->children();
On 2014/08/18 16:13:03, oshima wrote:
> can we use WindowListProvider::GetWindowList ?
> 
> I'd like to keep the logic to tell which windows are activity in one place.

Done.

https://codereview.chromium.org/481843002/diff/100001/athena/wm/window_manage...
athena/wm/window_manager_impl.cc:59: const gfx::Size container_size =
instance->container_->bounds().size();
On 2014/08/18 16:13:03, oshima wrote:
> gfx::Screen::GetPrimaryDisplay().work_area()

Done.

https://codereview.chromium.org/481843002/diff/100001/athena/wm/window_manage...
athena/wm/window_manager_impl.cc:62: if (is_splitview) {
On 2014/08/18 16:13:03, oshima wrote:
> I think it's better to let SplitViewController layout windows
> instead. WDTY?

That would work only for two windows: left and right. Instead of setting the
bounds directly for these two windows (lines 76, 78 below), we could let the SVC
decide the bounds (e.g. SplitViewController::LayoutSplitWindows()), but I don't
think we will be gaining much from that. If/once the layout becomes more complex
(e.g. with rotation), we could revisit this.

https://codereview.chromium.org/481843002/diff/100001/athena/wm/window_manage...
athena/wm/window_manager_impl.cc:90: return;
On 2014/08/18 16:13:03, oshima wrote:
> how about checking if the child window is in window list instead?

Done.

[oshima, 2014-08-18 17:00:41]

https://codereview.chromium.org/481843002/diff/100001/athena/wm/window_manage...
File athena/wm/window_manager_impl.cc (right):

https://codereview.chromium.org/481843002/diff/100001/athena/wm/window_manage...
athena/wm/window_manager_impl.cc:62: if (is_splitview) {
On 2014/08/18 16:45:43, sadrul wrote:
> On 2014/08/18 16:13:03, oshima wrote:
> > I think it's better to let SplitViewController layout windows
> > instead. WDTY?
> 
> That would work only for two windows: left and right. Instead of setting the
> bounds directly for these two windows (lines 76, 78 below), we could let the
SVC
> decide the bounds (e.g. SplitViewController::LayoutSplitWindows()), but I
don't
> think we will be gaining much from that. If/once the layout becomes more
complex
> (e.g. with rotation), we could revisit this.

I'm pretty sure we'll want to separate it, but ideal design may be different.
I'm fine as is for the time being.

[oshima, 2014-08-18 17:00:55]

oops, I meant lgtm

[sadrul, 2014-08-18 19:32:06]

Committed patchset #8 manually as 290330 (presubmit successful).