Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: base/files/file_enumerator_win.cc

Issue 48183005: Take advantage of some newer optimizations of FindFirstFile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/files/file_enumerator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/file_enumerator_win.cc
diff --git a/base/files/file_enumerator_win.cc b/base/files/file_enumerator_win.cc
index e47f5421a711b7ef1dea22cc0590cceb578216ab..6da1667ed99cc27f6da735965da13936ac1ef94b 100644
--- a/base/files/file_enumerator_win.cc
+++ b/base/files/file_enumerator_win.cc
@@ -8,6 +8,7 @@
#include "base/logging.h"
#include "base/threading/thread_restrictions.h"
+#include "base/win/windows_version.h"
namespace base {
@@ -99,7 +100,18 @@ FilePath FileEnumerator::Next() {
else
src = src.Append(pattern_);
- find_handle_ = FindFirstFile(src.value().c_str(), &find_data_);
+ if (base::win::GetVersion() >= base::win::VERSION_WIN7) {
+ // Use a "large fetch" on newer Windows which should speed up large
+ // enumerations (we seldom abort in the middle).
+ find_handle_ = FindFirstFileEx(src.value().c_str(),
+ FindExInfoBasic, // Omit short name.
+ &find_data_,
+ FindExSearchNameMatch,
+ NULL,
+ FIND_FIRST_EX_LARGE_FETCH);
+ } else {
+ find_handle_ = FindFirstFile(src.value().c_str(), &find_data_);
+ }
has_find_data_ = true;
} else {
// Search for the next file/directory.
« no previous file with comments | « base/files/file_enumerator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698