Issue 48183005: Take advantage of some newer optimizations of FindFirstFile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48183005: Take advantage of some newer optimizations of FindFirstFile. (Closed)

Created:
7 years, 1 month ago by brettw

Modified:
7 years, 1 month ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Take advantage of some newer optimizations of FindFirstFile. This sets the "large buffer" flag for file finding which is supposed increase throughput at potentially increased latency. Since we seldom interrupt find operations and don't block the UI thread, this should improve performance slightly. This also sets the "basic information" flag which will omit the short filename, which the documentation says should make it a bit faster. I checked and there is currently no user of this data. See also: http://blogs.msdn.com/b/oldnewthing/archive/2013/10/24/10459773.aspx BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231490

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	base/files/file_enumerator.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	base/files/file_enumerator_win.cc	View	1	2 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/48183005/30001

7 years, 1 month ago (2013-10-28 21:39:16 UTC) #3

Message was sent while issue was closed.

Change committed as 231490

Expand Messages | Collapse Messages