Chromium Code Reviews

Issue 48183002: Better triaging for this failure: usage of Type.toString makes the test fail in minified mode. (Closed)

Created:
7 years, 1 month ago by ngeoffray
Modified:
7 years, 1 month ago
Reviewers:
scheglov, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Better triaging for this failure: usage of Type.toString makes the test fail in minified mode. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=29344

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+3 lines, -1 line)
M pkg/pkg.status View 1 chunk +3 lines, -1 line 0 comments

Messages

Total messages: 3 (0 generated)
ngeoffray
@scheglov: The problematic code is in java_core.dart, method isInstanceOf.
7 years, 1 month ago (2013-10-28 07:52:50 UTC) #1
kasperl
LGTM.
7 years, 1 month ago (2013-10-28 08:06:02 UTC) #2
ngeoffray
7 years, 1 month ago (2013-10-28 08:17:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29344 (presubmit successful).

Powered by Google App Engine