Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: gyp/jsoncpp.gyp

Issue 481823003: Roll jsoncpp, drop dependency on Chromium overrides. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/jsoncpp.gyp
diff --git a/gyp/jsoncpp.gyp b/gyp/jsoncpp.gyp
index 337f716a180e521e1932d268748321b3b203725b..b6efd87bf8e805fa30ef0b759fd6a36c1b3ff659 100644
--- a/gyp/jsoncpp.gyp
+++ b/gyp/jsoncpp.gyp
@@ -1,16 +1,6 @@
# Copyright (c) 2012 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-
-# TODO: This file was copied from the external dependency
-# third_party/externals/jsoncpp-chromium/jsoncpp.gyp , at revision 125399,
-# with directory paths modified to work at this level.
-#
-# It would be better for us to depend on that gypfile within the external
-# dependency, but so far we have been unable to make that work reliably.
-# See https://code.google.com/p/skia/issues/detail?id=1023
-# and https://code.google.com/p/skia/source/detail?r=7115
-
{
'variables': {
'skia_warnings_as_errors': 0,
@@ -32,29 +22,16 @@
'JSON_USE_EXCEPTION=0',
],
'sources': [
- '../third_party/externals/jsoncpp/include/json/assertions.h',
bungeman-skia 2014/08/19 14:11:10 In general, I rather like having the header files
- '../third_party/externals/jsoncpp/include/json/autolink.h',
- '../third_party/externals/jsoncpp/include/json/config.h',
- '../third_party/externals/jsoncpp/include/json/features.h',
- '../third_party/externals/jsoncpp/include/json/forwards.h',
- '../third_party/externals/jsoncpp/include/json/json.h',
- '../third_party/externals/jsoncpp/include/json/reader.h',
- '../third_party/externals/jsoncpp-chromium/overrides/include/json/value.h',
- '../third_party/externals/jsoncpp/include/json/writer.h',
- '../third_party/externals/jsoncpp/src/lib_json/json_batchallocator.h',
'../third_party/externals/jsoncpp/src/lib_json/json_reader.cpp',
- '../third_party/externals/jsoncpp/src/lib_json/json_tool.h',
- '../third_party/externals/jsoncpp-chromium/overrides/src/lib_json/json_value.cpp',
+ '../third_party/externals/jsoncpp/src/lib_json/json_value.cpp',
'../third_party/externals/jsoncpp/src/lib_json/json_writer.cpp',
],
'include_dirs': [
- '../third_party/externals/jsoncpp-chromium/overrides/include/',
'../third_party/externals/jsoncpp/include/',
'../third_party/externals/jsoncpp/src/lib_json/',
],
'direct_dependent_settings': {
'include_dirs': [
- '../third_party/externals/jsoncpp-chromium/overrides/include/',
'../third_party/externals/jsoncpp/include/',
],
},
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698