Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 481823003: Roll jsoncpp, drop dependency on Chromium overrides. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Roll jsoncpp, drop dependency on Chromium overrides. This rolls jsoncpp to head, crucially past "Added missing includes for std::istream." which has given us some grief in the past. And it's required to build jsoncpp against libc++. Vanilla jsoncpp works just fine for us, so no need for Chromium's overrides. Like all DEPS, only tools depend on jsoncpp. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3ba54fa0adb0a9bb81c09ef18d6f8cebea311a6f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -30 lines) Patch
M DEPS View 1 chunk +1 line, -6 lines 0 comments Download
M gyp/jsoncpp.gyp View 2 chunks +1 line, -24 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
mtklein_C
6 years, 4 months ago (2014-08-19 02:43:02 UTC) #1
bungeman-skia
lgtm, so long as everything keeps working https://codereview.chromium.org/481823003/diff/1/gyp/jsoncpp.gyp File gyp/jsoncpp.gyp (left): https://codereview.chromium.org/481823003/diff/1/gyp/jsoncpp.gyp#oldcode35 gyp/jsoncpp.gyp:35: '../third_party/externals/jsoncpp/include/json/assertions.h', In ...
6 years, 4 months ago (2014-08-19 14:11:11 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-19 14:13:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/481823003/1
6 years, 4 months ago (2014-08-19 14:13:39 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 14:21:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 3ba54fa0adb0a9bb81c09ef18d6f8cebea311a6f

Powered by Google App Engine
This is Rietveld 408576698