content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java - Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments and rebased the patch. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java ('k') | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/HistoryUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

index 9fd40c40dc22cfbf7cef2a99633164a4c04906b8..f8d8b0f0c841c866adf10ffa4e72c5474b5278a5 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

@@ -20,6 +20,9 @@ import org.chromium.content_shell_apk.ContentShellTestBase;

import java.util.concurrent.TimeUnit;

+/**

+ * Integration Tests for SelectPopup.

+ */

public class SelectPopupTest extends ContentShellTestBase {

private static final long WAIT_TIMEOUT_SECONDS = scaleTimeout(2);

private static final String SELECT_URL = UrlUtils.encodeHtmlDataUri(

@@ -87,7 +90,7 @@ public class SelectPopupTest extends ContentShellTestBase {

@Override

public void run() {

// Now reload the page while the popup is showing, it gets hidden.

- getContentViewCore().reload(true);

+ getContentViewCore().getWebContents().getNavigationController().reload(true);

}

});

onPageFinishedHelper.waitForCallback(currentCallCount, 1,