android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java - Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments and rebased the patch. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/ClearHistoryTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

index db3dcd85cd2d8ea93fa2844086f5a8ca9cd2d97b..d8dfe07802bb4549cbfad95d19149182d8f4adc0 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

@@ -259,7 +259,7 @@ public class AwTestBase

getInstrumentation().runOnMainSync(new Runnable() {

@Override

public void run() {

- awContents.getContentViewCore().reload(true);

+ awContents.getNavigationController().reload(true);

}

});

onPageFinishedHelper.waitForCallback(currentCallCount, 1, WAIT_TIMEOUT_MS,

@@ -355,7 +355,7 @@ public class AwTestBase

return runTestOnUiThreadAndGetResult(new Callable<String>() {

@Override

public String call() throws Exception {

- return awContents.getContentViewCore().getTitle();

+ return awContents.getTitle();

}

});

}