android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java - Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments and rebased the patch. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnFormResubmissionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

index 5aaa32f92c8c494b3e876ae48aaaa858e91fad2f..e0a7a946197f7756185b36df4349b565b7306db8 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

@@ -149,11 +149,13 @@ class AwWebContentsDelegateAdapter extends AwWebContentsDelegate {

public void handleMessage(Message msg) {

switch(msg.what) {

case msgContinuePendingReload: {

- contentViewCore.continuePendingReload();

+ contentViewCore.getWebContents().getNavigationController()

+ .continuePendingReload();

break;

}

case msgCancelPendingReload: {

- contentViewCore.cancelPendingReload();

+ contentViewCore.getWebContents().getNavigationController()

+ .cancelPendingReload();

break;

}

default: