Source/core/rendering/RenderBox.cpp - Issue 481753002: Use Shadow DOM to display fallback content for images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 481753002: Use Shadow DOM to display fallback content for images (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderBox.cpp

diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp

index 314199b1681c16e14f4087c4de03d0f749804f6e..46e2789973561f4b777b7e6af8276bd98eaf92dc 100644

--- a/Source/core/rendering/RenderBox.cpp

+++ b/Source/core/rendering/RenderBox.cpp

@@ -4047,7 +4047,7 @@ bool RenderBox::shrinkToAvoidFloats() const

static bool isReplacedElement(Node* node)

{

// Checkboxes and radioboxes are not isReplaced() nor do they have their own renderer in which to override avoidFloats().

- return node && node->isElementNode() && toElement(node)->isFormControlElement();

+ return node && node->isElementNode() && (toElement(node)->isFormControlElement() || isHTMLImageElement(toElement(node)));

esprehn 2014/09/05 00:47:52 Can we break this up into a series of return state

}

bool RenderBox::avoidsFloats() const